Git Product home page Git Product logo

sketchcontentsync's People

Contributors

contentsync avatar dbrody avatar tastycode avatar willdavis avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

sketchcontentsync's Issues

Symbols Not Syncing

Opened up ContentSync today to an update. Updated to latest and it noticed that Symbols were not syncing.

All other content was syncing fine, but anything that was a Symbol would not sync.

Text Without Key Changing In Sketch File

I'm having an issue where text layers without the sync: designation are still changing. They are items I didn't set up in a excel doc but somehow are still changing.

Non-Latin character set styles

Great project. This isn't so much an issue as encouragement:

I'm currently doing lot of work with Chinese/English designs, and you generally need to use different fonts (and font sizes, weights, spacing, line height, etc) to make typography look good with non-Latin character sets.

So whilst this plugin makes it easy to collate translations and add them to a sketch file, when working with non-Latin alphabets a designer will still need to do an amount of manual tweaking to optimise the design.

Ability to change keys in spreadsheets

Is it possible to push all content to a spreadsheet, then change the keys in the spreadsheet instead of within the sketch file manually?

This is useful when we have a designer that is creating things quickly without thinking about the content, and allowing our copy writers to update this themselves.

Allow for automatic translations

Request

Make it easy to translate a design with minimal effort. Using Google translation services, add the ability to translate a design.

Details

  • Specify source / destination languages
  • Create new version automatically with the translated content

Doesn't work with multiple artboards

Hi there, I've noticed that this sync system doesn't seem to work across multiple artboards.

For example if I have multiple 'sync:' fields on multiple artboards, and try to update them all, only the first artboard is sync'd. The rest remain as they were. Probably this has something to do with the recent Sketch update.

Hope it's a simple fix! And thanks again for all the great work you've put into this already. ๐Ÿ‘

Issue with sync document in account Google enterprise

Hi, I have a enterprise account in Google and this don't permit publish google document if you aren't logged with the account of enterprise before. Yes it permit publish the docuement like other one, but only view for account of the enterprise.
Is there some way for do the sync if isn't the document public for everyone?

Thank in advance!

Allow 'Share Values Across Common Names'

Current Limitation

Currently, when the 'Include Layer Context Details' is toggled, it prevents multiple text layers from using the same values.

Proposed Solution

This is to add another settings option to 'Share Values Across Common Names'. This would allow a single entry on google documents to have multiple paths which would allow for having multiple layers share one entry.

Example

Given

Two artboards artboard1 and artboard2 both with a text layer named text.

Result

With this feature toggle ON:

One row would be created on google documents with the path cell of value with multiple lines:

Object ID Path Key
objectID1
objectID2
artboard1.text
artboard2.text
Key

Both of the text fields would always sync with the same data on a pull.

With this feature toggle OFF:

Two rows would be created on google documents with a single path per entry:

Object ID Path Key
objectID1 artboard1.text Key1
objectID2 artboard2.text Key2

Each text layer could have different values on a pull.

Pulling not starting a Pull

When clicking "Pull Content", button goes dark green into active click state, but then after a few seconds returns to normal state and does nothing.

I tried creating a new project and adding a excel doc from there...still no luck. Only seems to happen on this one Sketch file I have. All others are working properly.

Thoughts?

Content Keys non detected

I have a problem with the plugin, I have a Google sheet with 765 rows, when I try to refresh the linked content in my web panel in contentsync.io does not detect the content keys. I've tried all possible formats and I think it's a problem with the number of rows the script can read. Could you tell me please how I can solve this problem?

Google Drive account permissions

The company I work for has a corporate Google Drive account and I'm wondering what kind of additional permissions need to be set in order to use sheets on there?

Sketch Content Sync keyboard shortcut

I noticed the shortcut to toggle this plugin is โŒ˜=. That's the default key in sketch to zoom in. Can you guys change it or give me guidance how I can overwrite it? Keyboard shortcuts in accessibility seem to no do the trick.

Thanks!

Ability to override Symbols

Request

Hi @dbrody, you did an awesome plugin.
It would be great have the possibility to override symbols and push in Google Sheet their content so copywriter can update them.

Is it feasible?
Thank you so much

ContentSync Platform Error

Hi,

i'm getting this alert evertime i try to use the plugin. I tried multiple logouts and logins without result.
Any ideas?

bildschirmfoto 2017-02-21 um 09 58 58

Ability to disable font size when pulling from Google Sheet

It would be awesome if allow to disable only specific font properties.

I used ContentSync most for responsive project, and the ability to use a single source (Google Sheet) for several target would be awesome. It could be done using the same layer name. In this way, when pulling a new version from Google Sheet it will update all layers with that name. It's important (for responsive projects) to don't consider the font size when pulling (because in mobile views font size are maybe smaller than the desktop ones). For this reason I suggest to let users choose what font properties disable (ex. font-size, color, all of them).

Do you think that it will be possible?

Thank you

Extremely slow

Anyway to speed up the sync? Also crashes if you go between Windows. Not stable when multitasking.

Crashes when installed with SketchRunner

Followup to #56 since this is more context to the actual issue.

It appears there is an issue when installing it with SketchRunner. I sent a message to SketchRunner and waiting for a reply.

App Shortcut in Sketch

With the "Enable Shortcuts" on, pulling from within Sketch opens the ContentSync app, but I still have to click what "version" to pull after I click a version within the SketchApp box.

Is it intended to automatically pull the version you select?

If not, have you considered having it automatically pull?

No actions in the plugin's menu

Hi,

I've successfully installed the plugin but when I try to reach the "Google sync" item in the plugin's menu it fails, the list is empty and I can't go further than this screenshot:

image

Any ideas?

(I'm on Sketch 39.1 (31720))

Support Sketch 45 plugin update system

Hi there!

This is a quick note to remind you that Sketch 45 will include a plugin update system.

It would be awesome if you could add support to it (it's really easy!) before Sketch 45 comes out. Ideally, you should release an update for your plugin while we're still in Sketch 44, so your users will have a nice & easy experience when 45 is released.

For more details, please check http://sketchplugins.com/d/229-updating-plugins and http://developer.sketchapp.com/introduction/updating-plugins/

Thanks in advance!

ContentSync Plugin pane gone after 3.0.4 update

Two issues:

  1. I was using the old version of the plugin, and it stoped syncing... It was working intermittently, but now won't sync at all. In my account, it registers that the sync has gone through (https://www.contentsync.io/simonesept/gmb_master_redacted_aug11_l10n_final-sketch/activity), but the copy in the file isn't updating. I noticed that my plugin had an update pending, so I updated it, which led to:

  2. In sketch, the plugin pane on the far left where the upload/download buttons were is missing. The plugin is still showing as installed, and I've tried to Toggle it to make it appear, but it's not there.

Things I've tried:

  • using a different version of the sketch file linked to the same google sheet
  • uninstalling the plugin and reinstalling
  • uninstalling sketch entirely and reinstalling sketch and then the plugin

Help please!

Sketch Username: simonesept
Sketch filename: GMB_MASTER_REDACTED_Aug28_L10n_final_V6.sketch

Crashes Sketch (v3.0.0)

This could be more of a conflict between 2 plugins... but when I installed this plugin (via SketchRunner), Sketch crashed and I couldn't open any sketch files without crashing the program. Finally I figured out to go to Sketch > Plugins > Manage Plugins... and disabled some plugins until I found that disabling this plugin allowed me to open sketch files again.

I can send a list of my plugins if you think it might be a conflict.

Copy/Paste issues

As soon as I run the plugin on a slightly more complex Sketch-file, I have no longer the ability to copy/paste within the document. Duplicate (CMD+D) does work, but CMD+C/V/X doesn't do anything or has the app crashing.

Running the latest version of Sketch; 40.3

Generate keys in spreadsheet from .sketch file

Hi,

Great project! I've got a feature request. It would be great if all the keys in the spreadsheet could be generated from the layers named "sync:" in a sketch file.

In my case I've made loads of screens in Swedish and would like to just generate a spreadsheet with all the keys and the Swedish version in one column. Then translate everything to English in another column, and sync to see that the design doesn't break.

Thanks,
Kimmy

Issue with 'Google Sheet per Sketch Page' for Sketch files with many pages

Overview

If a Sketch file has many pages (on order of 15 or more) and the option to have a separate 'Google Sheet per Sketch Page' is toggled on, some pages may result with a rateLimitExceeded: Insufficient tokens for quota 'ReadGroup' and limit 'USER-100s' of service 'sheets.googleapis.com' for consumer 'project_number:167198436389'. error.

Impact

If this issue occurs, than pages that experience the rateLimitExceeded issue will not be synced. Other pages / sheets will be. So pushing / pulling may be partial.

Status

We are actively working on a fix for this.

Issues with symbol instance keys

Currently, syncing symbol instances does behave as expected. Details below:

Example

Given

A text layer text with a symbol subsymbol within another symbol symbol as represented by symbol > subsymbol > text.

Expectation

It should first look for a key name text[symbol][subsymbol]. If this is not found, then it should look for text[symbol] followed by text. This is known as key qualifiers and it should try the most specific one first, followed by less and less specific ones.

Issue

Currently, it only looks for the most specific key text[symbol][subsymbol] and does not look for the other qualifier variants.

Impact

This will cause issues on both pushing and pulling. It will cause blank fields on a push and cause improper values on a pull.

Status

We are currently looking into this and expect to have a solution by Monday, April 24th.

Support for private sheets

There have been a couple of people asking for access to private sheets without the need to publish the sheet to web. While sheetsu does help, there may be alternatives that work better for other use cases.

If anybody has desire for such feature, could you please comment a bit about your use case and what your ideal solution would be?

Initial thoughts are to use Google OAuth.

Ability to allow/disallow certain text fields

Would there be a possibility in a future release to exclude certain text fields using a key e.g ~aTextfield... or turn it around, only text fields with a certain char / key will be pushed to google sheets?

Ability to have reusable variables across layers

Current Limitation

Currently, content keys can only be complete values. A given item in the spreadsheet must be completely used within a text layer. It would be great to allow for partial values to be reused throughout a design.

Proposed Solution

Allowing variable names within content would help make content more easily dynamic. A example would be:

Key Value
Name ContentSync
Welcome Welcome to {Name}

Using { ... } would allow for replacing the value of another key into the content of a key.

In this example, the value for key Welcome would be 'Welcome to ContentSync'.

Plugin isn't working

Tried downloading and installing the plugin. There seems to be a .sketchplugin file missing from the .zip file. Renaming the file extension to .sketchplugin does not work either.

Override symbols content

To improve the productivity and scalability of the designs we usually turn module assets into symbols, e.g. buttons, these can be used in different screens with different labels overriding the original... can the symbol layer name be the trigger to override the content instead of the actual text layer inside the symbol?

Duplicate layer names are all treated as the same content

Issue

If there are many layers throughout a design that have the same name, they will all be treated as the same content. This is an issue when pushing / pulling as it will overwrite some of the content with data from other locations in the sketch.

Potential Solutions

More Context To A Key

One proposed solution is to use context to expand on a text field's name. So if I have a text layer named "Text" on an artboard name "Artboard" instead of the current key Text it would be something such as Page.Artbord.Text. If the layer is then within a Layer Group for example it would be: Page.Artboard.Layer Group.Text.

Use ObjectIDs

Each object in Sketch does have a unique key. This could be added as an additional metadata column in the Google Spreadsheet either as an additional Column A.

Etc

Other potential solutions...

Ignore text layers on Push

Hey @dbrody

Now that there is no need to add the "sync:" prefix to text layers I want to sync, I find when I do an initial Push on a new project I have many text layers that I don't need to sync (e.g. device keyboards, font icons, text design elements... etc.) I could "X" every text layer I don't want to push but, I'd have to do that again on any subsequent Push. So, either I need a way to tag text layers that I don't want to sync at all in my sketch file OR after the initial Push where I deselect each text layer I don't want to push, that somehow persists on subsequent Pushes. (I think I just confused myself)

Thanks

Support nested symbols

Really like the new symbols support, the only thing I'm missing is support for nested symbols.

For example:

  • I have a row with an avatar, name and job title
  • If I select them and create a symbol the overrides work as advertised
  • If I make a symbol out of the title and job title labels they don't get synced anymore

Symbol content sync broken in Sketch 41?

Looks like the symbols API changed week ago when Sketch released version 41.

Symptoms: after updating Sketch, contentSync neither imports content into 'sync fields' within symbol instances, nor overrides content in symbols where it should. Normal (non-symbol) text fields update as expected.

Hopefully it's not a big fix. Let me know if you're not getting this behaviour with Sketch 41; it's possible I've made a mistake somewhere.

The plugin generate a error with symbol

Hello,
I observed a bug when I use symbol. The plugin don't synchronise the text and generate a error. :)

P.S : Your plugin is very nice and useful.

27/11/16 19:46:02,329 Sketch[627]: Exception: TypeError: _layer.applyOverrides is not a function. (In '_layer.applyOverrides(mutableValues)', '_layer.applyOverrides' is undefined) 27/11/16 19:46:02,329 Google Sync (Sketch Plugin)[627]: TypeError: _layer.applyOverrides is not a function. (In '_layer.applyOverrides(mutableValues)', '_layer.applyOverrides' is undefined) line: 126 sourceURL: /Users/victorien/Library/Application Support/com.bohemiancoding.sketch3/Plugins/SketchContentSync.sketchplugin/Contents/Sketch/sync.google.cocoascript column: 26 stack: sync@/Users/victorien/Library/Application Support/com.bohemiancoding.sketch3/Plugins/SketchContentSync.sketchplugin/Contents/Sketch/sync.google.cocoascript:126:26 updateTextBoxes@/Users/victorien/Library/Application Support/com.bohemiancoding.sketch3/Plugins/SketchContentSync.sketchplugin/Contents/Sketch/sync.google.cocoascript:250:25 onRun@/Users/victorien/Library/Application Support/com.bohemiancoding.sketch3/Plugins/SketchContentSync.sketchplugin/Contents/Sketch/sync.google.cocoascript:219:24

screen shot 2016-11-27 at 19 49 02

screen shot 2016-11-27 at 19 54 23

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.