Rename ociRef.NewImageDestination to ociRef.NewLayoutDestination about image HOT 8 CLOSED

Sure, let’s do it now. Though OCIImageLayoutDestination is a bit of a mouthful; would just OCIImageDestination work? Or OCIDirectoryDestination to be specific that this is unpacked, not a single file, nor an installed image.

from image.

OCILayoutDestination, sounds good?

from image.

Works for me.

from image.

so there is oci.NewReference which then can do ociRef.NewImageDestination - I'll do ociRef.NewLayoutDestination

from image.

That would not conform to ImageReference, and anyway an ImageReference to a local directory and an ImageReference to a remote registry are different things with different concepts and semantics.

It is perfectly fine to have them in the same package, but they should be separate ImageTransports with separate ImageReference implementations.

from image.

i.e. oci{Layout,Registry}{Transport,Reference}' types. The references can be of course created using helper functions (i.e. without going through theTransports),oci.NewLayoutReferenceandoci.NewRegistryReference`.

from image.

oci.NewLayoutReferenceandoci.NewRegistryReference`.

👍

from image.

@mtrmac re-thought about this, making a PR

from image.