Git Product home page Git Product logo

Comments (3)

mtrmac avatar mtrmac commented on August 22, 2024

Thanks for your report.

Pedantically, I’d argue that the spec already implies this by referring to RFC 4880 section 11.3. , which refers to specific binary packet formats, and does not talk about ASCII armor; but it’s clearly not explicit enough.

Pragmatically, much more important is that the implementation chosen by the containers_image_openpgp build tag has always rejected ASCII-armored signatures, so they were not widely interoperable (E.g. CRI-O is rejecting them in the default build).

So, I am proposing #1854 .


As much as I would like to ask for (or provide) handling for content of this sort,

Why is it useful?

To me it seems to only add unnecessary ambiguity, implementation complexity, and data size, for no end-user benefit; if anything, it adds risk because it makes it easier for users to see, and potentially rely on, the contents of the signature without actually verifying its authenticity.

I may well be missing something; what is it?

(Arguably, “we have tons of content signed that way” could count as a good enough reason alone… but, it’s, shall we say, not an elegant reason.)

from image.

mtrmac avatar mtrmac commented on August 22, 2024

BTW if past signed content is the only reason, I wouldn’t object too strongly to detecting and allowing the ASCII-armored signatures through, and letting GPG deal with them the way it has done; that adds little to no signature verification risk. I would be much less happy about actually adding ASCII armor implementation to the containers_image_openpgp code path, that would directly be adding rarely-used code to a critical signature verification code path.

from image.

dwmarshall avatar dwmarshall commented on August 22, 2024

#1854 is a satisfactory resolution. Thanks, @mtrmac!

from image.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.