consenlabs / eos-bp-profile Goto Github PK

We have already added the pull requests #125.
Thank you very much!

Hello!
I have validated our JSON to be valid:

Requesting to merge our pull request since it's been out for 2 days now:
#134

Attn: @makoshan

account_name 和 public_key 是什么

I am currently producing a BP JSON file which is very similar to the one described in this repo, but not exactly.

https://github.com/EOSPortal/bp-info-standard
https://github.com/eosrio/bp-info-standard

Note that this EOS BP standard has a Schema, so I've written a small app that produces my JSON and validates it against the provided schema.

While I could (and will if that's your desire) produce another JSON file to your spec, I feel you may want to consider using this other spec and it's schema file. This will allow people to validate their JSON before providing it to you ... it also mean we have one standard and not 10 :) ...

Let me know what you think please. I think think this will also save you a lot of trouble in the future.

In order to properly show non-English characters (i.e. Chinese or Korean) properly in a text file an encoding other than ANSI should be used (i.e. UTF-8). However, modifying the encoding of the [bp_name].json file causes the build test to fail. If UTF-8 is used, executing npm test and npm install will result in the following error.

ERROR! json file name [bp_name].json parse error, please check first (maybe has some unnecessary space or comma symbol like ",")

Changing the encoding back to ANSI patches this issue, but non-English characters do not display properly when editing the file.

We have already send the pull request for merging our BP information, submitted the required files. #144 The waiting time for merging a bit longer as many request that submitted later than us has already be merged. We want some feedback to tell us how the situation is going on or if there is any problem for merging our submitted documents！Thanks alot!

ERROR! json file name UnlimitedEOS.json parse error, please check first (maybe has some unnecessary space or comma symbol like ",")

but my file is emergepoland.json -- not UnlimitedEOS.json

Please add some guidance to the readme of this repo on what the dimensions of the logo and cover image should be.

hi
if you really want to help current BPs already have a bp.json uploaded to their sites
e.g. EOS Romania has it here
http://eos.romania22.com/bp.json

each BPs have their bp.json loaded on their websites
so why don't you just use those?

thank you