conradsoon / pe Goto Github PK

find command allows searching by exact subword
find Bernice

vs

search command requires searching by full name

It is not specified in UG that search command requires matching by full-name, and as such it's a valid assumption to have that search command behaviour will follow format of find command, which allows searching of name by exact subword.

Issue

There is no length validation performed for phone numbers

There is no specification as to the format of DAY_OF_THE_WEEK. As a user, I'm not sure if I'm supposed to use MONDAY, MON, or MO.

The example as provided in the application should be search m/CS2100, not searchm/CS2100.

In the UG, the search command is specified as above, but actual usage is without commas. It might be helpful to remove the commas so users have a clearer understanding of how to use the command (whether to put commas or not).

As a user, I'm not sure how exactly to format the 12_HOUR_CLOCK_TIME in addTutorial due to lack of specification in the UG. For example, is 10.30PM allowed, or is 12:00PM allowed?

addToModule command does not admit multiple module tags, which may result in worsened user experience if tutor has to manually add the same student to multiple different classes.

addModule m/Booboooboo  m/Blahblah

Running addModule with multiple m/ fields returns an incorrect error message.

In this case, there are no non-alphanumeric characters being used, but the app wrongly declares it otherwise.

Correct error message should be something along the lines of multiple m/ tags used, please only use one!.

dfdsfsdf

addTutorial m/CS2100 tt/Mon 12:30pm tn/bnlah

However, there may be tutorials which do not start exactly at whole hours, and as such this is a feature flaw.

In the situation where I might be teaching >5 or more tutorials, the tutorials list actually overflows, preventing me from being able to read out the list of tutorials I am currently teaching. This hinders me from being able to use commands such as addToTutorial or deleteTutorial effectively, as I am unable to find the index for the tutorial I wish to modify.

There should be a scrollbar, or some other way of displaying the tutorials being taught, such that I am able to continue using the product even when I am teaching a lot of tutorials.

Currently, the header showing modules and tutorials does not show an index. This means that if we want to find the index of a certain tutorial to reference, we have to manually count the modules and tutorials to find the index, which leads to a worsened user experience.

Additionally, given the fact that your addModule and addTutorial commands allow for names with spaces in them, this can lead to disambiguity.

Consider
addTutorial m/CS2100 tn/CS2100 Mon 12pm tt/MON 12pm
addTutorial m/CS2100 tn/Tue 12pm tt/Tue 12pm

In this case, it is unclear what index each tutorial occupies.

These diagrams in the DG are not formatted properly and are cut-off.

Running addTutorial m/CS2100 tn/T1 tt/MON 12pm addTutorial m/CS2100 tn/T2 tt/MON 12pm does not give me an error even though these two tutorial slots occupy the same timings. Tutorial timings should be unique.

There is no disambiguation between attendance tags and actual tags in the UI, which is confusing.

You should make one a certain colour, to allow for disambiguation between the two.

Suppose I add a few attn with attn 1 ln/L1

Then I change the tags on 1 with edit 1 t/change

This deletes the attendance of the student from the UI, which is unexpected behaviour.

Additionally, I am unable to add back their attendance again, as it throws an error message as such.

I'm unable to add students with non-English names into the application. add n/张德明 p/98765432 e/[email protected] s/A0240253J tele/@john t/friends. In this case, a student with a Chinese name cannot be added into the application.

dsfsd

Running search m/dl (which is incorrect input) does not give me any error message to help me debug why this is incorrect.

In documents, it is stated
Keywords are case-sensitive, only NAME is case-insensitive.

As such, running search n/Bernice Yu and search n/bernice yu should return the same results.

However, only the former works. The latter returns no results.