connlim / ped Goto Github PK

Expected

Examples for editTask command usage in the UG.

Actual

UG contains the correct format for editTask, but the examples use the command edit edit instead. The edit command should be replaced with editTask.

E.g. edit 1 n/Create UI pr/high -> editTask 1 n/Create UI pr/high

Steps to reproduce

Enter the help command into the app.

Expected

App opens a window with a list of command a user can try, as stated in the user guide.

Actual

App opens a window with a link to the wrong user guide (SE Education user guide).

Suggestion

The link should either point to the correct user guide or the window should display a list of command directly.

Expected

The UG contains a section explaining the listTasks command. It should explain what the listTasks command does and how to use it. The command simply displays a list of tasks in the task tab and the UG should match that accordingly.

Actual

The UG states the following for the listTasks command:

Edits the details of the task identified by the index number used in the displayed task list. Existing values will be overwritten by the input values.

This is inaccurate as the listTasks command cannot edit tasks.

Steps to reproduce

Use Fedora Linux 36 (or any other Linux distro) with GNOME shell desktop environment running a Wayland session. Attempt to launch the app.

Expected

App launches and shows a window.

Actual

App craches with an error. The issue is likely due to out-of-date JavaFX version. The version of JavaFX in the default tp project has a bug making it unable to use launch under XWayland when in a Wayland session. Updating JavaFX dependencies should fix the issue

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x0000000000000002, pid=117496, tid=117543
#
# JRE version: OpenJDK Runtime Environment (Red_Hat-11.0.16.1.1-1.fc36) (11.0.16.1+1) (build 11.0.16.1+1)
# Java VM: OpenJDK 64-Bit Server VM (Red_Hat-11.0.16.1.1-1.fc36) (11.0.16.1+1, mixed mode, sharing, tiered, compressed oops, g1 gc, linux-amd64)
# Problematic frame:
# C  0x0000000000000002
#
# Core dump will be written. Default location: Core dumps may be processed with "/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h" (or dumping to /home/connor/Documents/2022/Fall/CS2103T/PE-Dry/core.117496)
#
# An error report file with more information is saved as:
# /home/connor/Documents/2022/Fall/CS2103T/PE-Dry/hs_err_pid117496.log
#
# If you would like to submit a bug report, please visit:
#   https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&component=java-11-openjdk&version=36
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

System Information

$ cat /etc/os-release
NAME="Fedora Linux"
VERSION="36 (Workstation Edition)"
ID=fedora
VERSION_ID=36
VERSION_CODENAME=""
PLATFORM_ID="platform:f36"
PRETTY_NAME="Fedora Linux 36 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:36"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f36/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=36
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=36
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

$ uname -r
5.19.16-200.fc36.x86_64

$ gnome-shell --version
GNOME Shell 42.5

$ echo $XDG_SESSION_TYPE
wayland

Expected

I should be able to unassign a person from a task, as it is optional to have a person assigned to a task. The edit command lets me use an empty tag to delete all tags a person has e.g. edit 2 n/Betsy Crower t/ Edits the name of the 2nd person to be Betsy Crower and clears all existing tags. I would expect the editTask command to also do something similar with the assigned person.

I should also be able to clear the assigned person when editing a task: editTask 1 pe/

Actual

Running the command editTask 1 pe/ results in an error:

Invalid command format! 
Emails should be of the format local-part@domain and adhere to the following constraints:
1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters.
2. This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods.
The domain name must:
    - end with a domain label at least 2 characters long
    - have each domain label start and end with alphanumeric characters
    - have each domain label consist of alphanumeric characters, separated only by hyphens, if any.