confluentinc / pmm Goto Github PK

@jwfbean could you include the link to your reference architecture? https://www.confluent.io/resources/white-paper/hybrid-and-multicloud-reference-architecture/

CP Demo recently added Gitpod by adding a .gitpod.yml file to the repo root. The user experience is MUCH improved, especially with prebuilds enabled. I highly suggest adding Gitpod!

In the messaging modernization lab, I notice the user is supposed to do some setup for various jars and build docker images first. Perhaps we could use the docker compose build directive so that docker compose will automatically build those images.

Better yet would be to build and publish those images to dockerhub ourselves so the user doesn’t have to build them locally.

I also notice some connectors being installed on the connect container on startup. Same idea as above — we could bake that into a new docker image instead of requiring that at launch time.

One more thing I notice is the use of depends_on. In my experience, this only actually checks whether a container is running, not whether the service is actually running. This means in some cases, services will fail unpredictably. To solve this, we can use the healthcheck directive. The Confluent docker images come with the cub utility that can be used for a health check. I think cp demo implements this, but I’d have to check.