Git Product home page Git Product logo

Comments (3)

ethanfrey avatar ethanfrey commented on August 25, 2024
  1. Make some counter proposals to this api design or accept it.
  2. Make a draft pr showing how to pass the logger into the system so it is not a pain and gets down to ibcclient
  3. After review of above, add logging commands

from ts-relayer.

ethanfrey avatar ethanfrey commented on August 25, 2024
  • log verbose on every signAndBroadcast (saying what message sent)
  • log debug on every signAndBroadcast (showing the message body being sent, and gas paid)
  • we just throw errors, the caller is responsible for catching them and logging them as errors
  • if there is any case that really shouldn't happen, add a warn (i cannot think of one)
  • consider adding info/verbose calls for the high level link ones (createNewConnection -> log.info("creating new connection between musselnet-4 and bifrost-2"))

Later we can review these with user feedback. Log all/some queries at debug/verbose level? What to add/remove?

This issue is just to get a good attempt at logging to iterate on

from ts-relayer.

ethanfrey avatar ethanfrey commented on August 25, 2024

One user is our integration tests. We should be able to turn up log-level to debug and rerun tests and get useful information to start pinpointing the error (and from there maybe more debug statements). We can pass in a mock logger that just goes to console and ignores any level not explicitly enabled.

from ts-relayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.