conda-forge / benchmark-feedstock Goto Github PK

@conda-forge-admin,please add bot automerge

I believe the issue is that in the build script we loop over SHARED being ON then OFF, so the static lib is built second and its CMake files overwrite the shared lib produced ones: https://github.com/conda-forge/benchmark-feedstock/blob/master/recipe/build.sh#L9

Given CFEP-18: https://github.com/conda-forge/cfep/blob/master/cfep-18.md should we just remove the static build altogether?

Hello,

Google benchmark supports some (minimal but hopefully growing) Python bindings.
They are shipped on PyPI under the name google-benchmark.

I was wondering if it could be relevant to add them to this repository, or maybe to create a new one.

Thanks!

Issue:
Package benchmark-1.5-he1b5a44_1.tar.bz2 contains incorrect path in lib/cmake/benchmark/benchmarkTargets.cmake:

set_target_properties(benchmark::benchmark PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "-pthread;/home/conda/feedstock_root/build_artifacts/benchmark_1558971149818/_build_env/x86_64-conda_cos6-linux-gnu/sysroot/usr/lib/librt.so"
)

this breaks Arrow build when using conda-forge environment (-DARROW_DEPENDENCY_SOURCE:STRING=CONDA).

$ conda list | grep benchmark
benchmark                 1.5                  he1b5a44_1    conda-forge