Git Product home page Git Product logo

Comments (6)

commenthol avatar commenthol commented on August 22, 2024

Hi @kodie, this package runs fine in modern browsers as is Chrome>=50 Firefox>=50 Edge>=15 Safari>=10. Would you mind sharing the exact browser version where you encounter this problem?

from astronomia.

kodie avatar kodie commented on August 22, 2024

@commenthol I'm not sure what bundler package you are using to get this package to work in a browser but with browserify it definitely does not work.

screen shot 2017-08-29 at 4 12 57 pm

This is with Google Chrome Version 60.0.3112.101 (Official Build) (64-bit)

I created a test package where you can see exactly where it's failing: https://github.com/kodie/date-holidays-bundle-test

I have also submitted a pull request with this issue fixed: #3

from astronomia.

commenthol avatar commenthol commented on August 22, 2024

Please make sure to either use meta charset=UTF-8 in your page

<html>
...
  <meta charset="UTF-8">
  ...

or include your bundle (e.g. bundle.js) with

<html>
  ...
<body>
  ...
  <script src="bundle.js" charset="UTF-8"></script>
  ...

Then all variables get resolved correctly.

from astronomia.

kodie avatar kodie commented on August 22, 2024

Wow! I did not realize it was that simple, haha. I stand corrected!

Still though, is there a reason why you would prefer to specifically instruct users to add the charset parameter when including the script rather than just convert all of the greek characters?

This gets things rolling but for example I'll have to add to the installation instructions:

Be sure to add charset="UTF-8" when embedding the script on your page due to the astronomia dependency needing it.

Not that that's a huge deal, but still a minor inconvenience.

Awesome package by the way.

from astronomia.

commenthol avatar commenthol commented on August 22, 2024

The package is a "translation" from go-lang and I like to keep things as close as possible. With the current set I still can easily incorporate fixes found in its parent. The greekish vars would make things more "unreadable" in such a case.

from astronomia.

kodie avatar kodie commented on August 22, 2024

Understandable! Thank you!

from astronomia.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.