Git Product home page Git Product logo

comma-api's Introduction

@commaai/api

comma API client library

Installation

You can install the package using the GitHub URL. It is recommended to use a specific version tag.

# add to your package.json dependencies

"@commaai/api": "commaai/comma-api#v3.0.1",

comma-api's People

Contributors

adeebshihadeh avatar andyh2 avatar chrisinajar avatar dependabot[bot] avatar gregjhogan avatar incognitojam avatar jwooning avatar sshane avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

comma-api's Issues

add types

  • generated types
  • add types to client

404 error when GET requesting route segments

A GET request to /v1/route/:route_name/segments with routes provided on comma web challenge and other public routes found on open pilot tools all return a 404 Not Found error.

Reproduction step:

Route provided by comma web challenge: 96850532278bae3b|000000dd--455f14369d

curl -H "Authorization: JWT {{token}}" "https://api.commadotai.com/v1/route/96850532278bae3b|000000dd--455f14369d/segments"

Result:

<html lang=en>
<title>404 Not Found</title>
<h1>Not Found</h1>
<p>The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.</p>

Better JWT tokens from jwt.comma.ai

Tokens are currently set to expire a year. If a token was to get compromised, one would not be able to do anything about it and would be subject to malicious acts.. snapshots, location, reboots.

A possible solution would be the ability to list tokens along with a revoke option, or simply a revoke all.

Another option is to create shorter lived tokens, but this does not fully solve the issue and leaves a user at risk until its expiration. This also requires recreating tokens more frequently which complicates everything.

Feature Request - Remove dist from repo and add CI

Congrats on open-sourcing such a great service! I'm really excited to be able to contribute to this. At first glance, I think it would be nice to remove the dist folder from the repo (since it's basically a compiled form of the src folder), and add the build step to a CI provider like CircleCI, so that the api can be built automatically once the code lands in master. I can create a PR if you'd prefer.

Once again, great work and congrats!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.