comit-network / rendezvous-server Goto Github PK

A simple Docker image for running a rendezvous server might be useful. Would help with making running one more reliable and easy.

Commandline args can be inspected through tools like top by any process on a machine. More info here: https://smallstep.com/blog/command-line-secrets/

Likely, we can just a file instead where the permissions can be restricted.

Logging all events is a bit noisy. We should identify which information we want and explicitly log that.

Blocked by libp2p/rust-libp2p#2109.

Must include builds for armv7 and Linux x64.
May include builds for MacOS and Windows.

Unsolicited feedback. Feel free to ignore.

Given that you are supporting a single authentication protocol only, you might want to consider using Version::V1Lazy instead of V1, potentially saving you one round trip. See V1Lazy docs for details.

Not important now but would be nice at some point.

I am not sure how much value they are adding over the examples that already exist in the rust-libp2p repository. I'd rather keep this repository simple.

Well-behaved unix processes print diagnostics like logging to stderr.

With only a single binary, we can move all the code into main.rs and it will by convention have the name of the crate.

While we are at it, I think we can just remove lib.rs altogether.

This project is a binary, not a library. It shouldn't expose a library interface. Might need to consider #9 as part of that.

Once/if libp2p/rust-libp2p#2142 lands, we can use the protobuf encoding of KeyPair directly to store the identity file. Saves a couple of lines of code to convert to/from ed25519 keys.