Currently Greenkeeper does not commit lockfile.

Currently even tagged versions on GitHub don't have dist files. It should be changed.

Move to @comandeer/eslint-config for linting.

Node.js 8.0 with npm 5.0 is released – let's add support for it!

Currently plugin does not have any API docs. It'd be nice to add some.

Commitplease will ensure that every commit adheres to the desired commit convention.

Currently package supports Rollup >= 0.41.5, however in the recent versions Rollup has changed how it parses options. Due to this fact, package now has two methods for passing parameters, which is not ideal. It would be nice to drop support for old versions of Rollup.

Steps to reproduce the issue

1. run rollup build without rollup-plugin-babel-minify, build successful
2. add minify and get the error

src/index.js → public/module...
[!] (babel-minify plugin) SyntaxError: Error transforming bundle with 'babel-minify' plugin: unknown: Support for the experimental syntax 'dynamicImport' isn't currently enabled (94:7):

  92 |     key: "handleClick",
  93 |     value: function handleClick() {
> 94 |       import("./moduleA.js").then(function (module) {
     |       ^
  95 |         console.log(module.default);
  96 |       }).catch(function (err) {// Handle failure
  97 |       });

Add @babel/plugin-syntax-dynamic-import (https://git.io/vb4Sv) to the 'plugins' section of your Babel config to enable parsing.
undefined (94:6)
SyntaxError: Error transforming bundle with 'babel-minify' plugin: unknown: Support for the experimental syntax 'dynamicImport' isn't currently enabled (94:7):

Babelrc is:

{
	"presets": [
		["@babel/env", {
			"modules": false
		}],
		["@babel/preset-react"]
	],
	"plugins": [
		["@babel/plugin-syntax-dynamic-import"]
	]
}

Running Babel via CLI babel src/App.js -o compiled.js with the following babelrc is successful:

{
	"presets": [
		["@babel/env", {
			"modules": false
		}],
		["@babel/preset-react"],
		["minify", {
			"mangle": {
				"topLevel": true,
			}
		}]
	],
	"plugins": [
		["@babel/plugin-syntax-dynamic-import"]
	]
}

Version of package: 6.1.1
Node.js & npm versions: 11.0.0, 6.4.1
Operating system: macOS 10.13.6

Currently tests are run against bundled, built version of the library. It would be nice to change that and run tests against ES6 source with only modules transpiled.

Greenkeeper does not support package-lock.json by default and requires use of greenkeeper-lockfile.

Currently all tests repeat the same boilerplate code. Extracting it to separate function would simplify whole tests a lot.

Babili from version 0.0.10 supports passing options. It would be nice to support it in a plugin.

• switch to @babel/core
• update plugins and presets
• update babel-register for tests
• update config

Due to fact that plugins are run before presets, new line inserted by @comandeer/babel-plugin-banner is removed by babili. Let's find some solution to hack this!

Steps to reproduce the issue

1. Use this plugin with following Rollup configuration:

   import minify from 'rollup-plugin-babel-minify';
   
   export default {
   	input: 'index.js',
   	plugins: [
   		minify()
   	],
   	output: {
   		banner: '/* hublabubla */',
   		file: 'bundle.js',
   		format: 'es'
   	}
   };

Expected result

The banner is outputted once at the beginning of the bundle.

Actual result

The banner is outputted twice.

Other details

Version of package: reproducible at least from 6.2.0

The issue is present only when banner is passed as rollup option, works fine when is passed as plugin's option.

Currently package.json has only jsnext:main field, which is deprecated in favor of module field.

prepublish script basically duplicates preversion one. Building package before versioning should be enough as published version is the same as versioned one.

The devDependency rollup was updated from 0.66.0 to 0.66.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rollup is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I forgot I had the name rollup-plugin-babili on npm.

Babili is renamed to babel-minify Ref: babel/minify#124

• Change name to rollup-plugin-babel-minify
• Publish to npm after babel-minify is published. I have the name rollup-plugin-babel-minify on npm.

Test adds banner inherited from root configuration is failing. Additionally rollup is raising warning for it:

The following options have been renamed — please update your config: banner -> output.banner

There are several issues with banner:

• banner option is not overriding top level options, it extends it
• banner in rollup accepts function, while string only is expected in plugin

PR is ready, I will submit it soon.

More badges = better!

Add code coverage with integration with CodeCov.

File:
https://github.com/Comandeer/rollup-plugin-babel-minify/blob/master/src/utils.js#L38-L44

Version:
v4.0.0

Problem:
return v != null && typeof v === 'string'; is tautology, because second statement fulfills first statement. There is no valid string, which is equal to null.

The same applies to return v != null && typeof v === 'function'; - there is no function that may be equal to null.

Fix:
Remove v != null statement.

Hiding commitplease behind Husky allows to skip git hook on CI.

Current fix for mappings is a bit brutal therefore it would be nice to test if generated maps are sensible. Maybe sourcemap-validator could be used for it?

As LTS is already 8 and 4 still has some issues with ES6 syntax, it seems to be safe now to deprecate support for Node <6.

Before support for older versions of Rollup is removed, let's gently depracate it!

• dedicated tests for utils
• tests for multiple chunks (API and CLI)
• tests for assets

Steps to reproduce the issue

// bundle.js
rollup({
  entry,
  plugins: [babel(babelConfig), babili()],
}).then(bundle => {
  bundle.write({
    format: 'umd',
    dest: `dist/umd/${dest}`,
    sourceMap,
    moduleName,
  });
  bundle.write({
    format: 'es',
    dest: `dist/esm/${dest}`,
    sourceMap,
  });
});

// babel config
const env = require.resolve('babel-preset-env');
const stage2 = require.resolve('babel-preset-stage-2');
const externalHelpers = require.resolve('babel-plugin-external-helpers');

module.exports = {
  presets: [
    [
      env,
      {
        targets: {
          browsers: ['last 2 versions', 'ie >= 10'],
        },
        modules: false,
      },
    ],
    stage2,
  ],
  plugins: [externalHelpers],
};

Expected result

The output bundle should be a compressed bunch of code.

Actual result

The output is not compressed at all...

Other details

Version of package:
latest

Node.js & npm versions:
latest

Operating system:
latest macOS

Version 0.41.2 of rollup just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As rollup is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

As LTS is already 8 and 4 still has some issues with ES6 syntax, it seems to be safe now to wait one version after #69 and drop support for Node <6.

Node 4 does not support default options used in codebase. Probably using rollup preset also for tests will solve the issue.

The code splitting in Rollup is done via import() syntax, which is not supported in Babel without appropriate plugin. Let's add this plugin by default.

This is what I get when I try to use this plugin:

TypeError: Cannot read property 'names' of null
    at new Link (/Users/federicozivolo/Progetti/popper-js/node_modules/rollup/src/utils/collapseSourcemaps.js:19:19)
    at /Users/federicozivolo/Progetti/popper-js/node_modules/rollup/src/utils/collapseSourcemaps.js:147:12
    at Array.forEach (native)
    at collapseSourcemaps (/Users/federicozivolo/Progetti/popper-js/node_modules/rollup/src/utils/collapseSourcemaps.js:146:23)
    at Bundle.render (/Users/federicozivolo/Progetti/popper-js/node_modules/rollup/src/Bundle.js:436:11)
    at generate (/Users/federicozivolo/Progetti/popper-js/node_modules/rollup/src/rollup.js:73:28)
    at Object.write (/Users/federicozivolo/Progetti/popper-js/node_modules/rollup/src/rollup.js:102:20)
    at /Users/federicozivolo/Progetti/popper-js/node_modules/rollup/bin/rollup:908:18
    at process._tickCallback (internal/process/next_tick.js:103:7)
    at Module.runMain (module.js:607:11)

Travis CI seems to force npm ci as a new install command, breaking GreenKeeper integration. Let's force "legacy" npm install.

Babel 7 is currently in beta, so it would be nice to test it alongside with Babel 6.

Add Rollup >= 0.41.5 as peer dependency will clearly state what minimal version of Rollup this plugin requires.

Steps to reproduce the issue

Add bannerNewLine: true to your rollup-plugin-babel-minify config.

Expected result

Newline should be added after banner, sourcemaps should not be cleared.

Actual result

Newline is added after banner, but sourcemaps also get cleared. By cleared, I mean that I get the following:

{"version":3,"file":"moneybutton.js","sources":[],"sourcesContent":[],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;"}

Disabling this option yields the complete sourcemaps.

Other details

Looking at the code, the bug seems to be in this line:

https://github.com/Comandeer/rollup-plugin-babel-minify/blob/master/src/index.js#L50

When calling addNewLine, the source maps generated by transform are completely disregarded.

Version of package: 6.0.0

Node.js & npm versions: 8.11.3 , 5.6.0

Operating system: Ubuntu 18.04.1 LTS

I'm currently getting the following warning when running rollup-plugin-babel-minify:

(!) babel-minify plugin: The transformBundle hook used by plugin babel-minify is deprecated. The renderChunk hook should be used instead.

Further information:

• [email protected]
• [email protected]
• node v10.14.2
• npm v6.4.1
• Ubuntu 18.04.1 LTS

Babel can use plugins alongside presets. Therefore rollup-plugin-babel-minify should allow passing additional plugins via plugins option:

rollupPlugin( {
	plugins: [
		'@babel/plugin-syntax-dynamic-import'
	]
} )

Seems like Greenkeeper didn't update this one.

Current version in use: 12
Latest version: 13

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴