comakery / comakery-eos-vesting Goto Github PK

Goal

Make it easy to run a script and deploy the contract to an EOS or Telos blockchain

Acceptance

• Can run a script to deploy the contract to a target blockchain EOS, Telos, mainnet/testnet including the ORE Telos blockchain
• Has a configuration file for selecting the target blockchain, admin account and the token that will be used in the vesting contract
• Usage documented in the README

Helpful Links

• ORE blockchain information https://aikon.com/ore-blockchain
• ORE blockchain explorer information https://explorer.ore.network/

Acceptance:

• Update the README usage instructions to be easy to follow top to bottom with instruction code that is verified to run
• Confirm that the example code runs on OS X
• Update the function calls in the Smart Contract Pseudocode section of the README to the actual implementation

Feel free to add, remove or modify steps for clarity or ease.

I tried running the tests, but I got errors again. I found in the code that after connecting the contracts, they are still used. For example:

https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L282
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L162
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L538-L541

And in the tests themselves of the contract:
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/vesting_contract_test.cpp#L89
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/vesting_contract_test.cpp#L217

So I think you still need contract files to run tests.

When running C ++ tests, an error occurs. After examining the repository, I realized that before starting the tests, the environment is set up, in which the contracts are deployed, which are used in tests and in the main cmkryvesting contract. All this is implemented in the file https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp. I found that the error is happening because the other contracts file is missing. Here is a list of files and contracts that are not in the repository.

dappservices.wasm
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L333

EOSDTNUTOKEN
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L337

EOSDTSTTOKEN
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L338

EOSDTKGTOKEN
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L339

EOSDTORCLIZE
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L353

EOSDTCNTRACT
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L354

provableconn.wasm
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L356

EOSDTLIQDATR
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L363

EOSDTGOVERNC
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L364

EOSDTEXCHANG
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L365

TOKENSWAP_EQ
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L366

EOSLOTTERYEQ
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L367

EOS2DTDOTCOM
https://github.com/CoMakery/comakery-eos-vesting/blob/main/cmkryvesting_tests/common.hpp#L373

Acceptance

• In the cmkryvesting_tests add an automated test scenario with vesting and lockup together.
• The automated test runs in GitHub actions with the other CI tests

Testing Scenario: Vesting & Lockup Together

The employee received a 100 day vesting with a 100 day lockup for 100 tokens.
The start date is set to 50 days ago,
The employee is fired and the remaining vesting is canceled.
The admin reclaims the 50 unvested tokens.
The employee owns 50 tokens but they are still locked until the lockup period is over.
The admin tries to claim the 50 vested employee owned tokens but the reclaim fails.
99 days from the start date the employee tries to transfer 50 tokens but the transfer fails because they are still locked.
100 days from the start date the tokens unlock and the ex-employee transfers their 50 tokens successfully.

Possible additional changes

If it's not possible to set both the Vesting & Lockup at the same as specified in the scenario, modify the contract to be able to set them separately.

Goal

Make it easy to write automated javascript code by providing working example code in the README and automated tests.

Note that the scope of this issue isn't full test coverage in Javascript.

Acceptance:

• Select the best Node.js library for making calls to the EOS contract
• Add working example code for calling the EOS contract with Javascript.
• Add documentation to the README
• Add a few automated javascript test demonstrating private key generation, calling the contract as an admin and calling the contract as a vesting recipient.
• The tests should be run in GitHub actions CI along with the other automated tests