colmbrady / lottie-reactxp Goto Github PK

Publish this library to NPM

Once the storybook is improved, share it to github pages so people can easily see this module in action without having to setup a dev environment.

Storybook wont work on Android because Android SDK is set to 23.

I think it would be great to have a better demo storybook, at least as good as the Lotties example app. Perhaps using some of that code and Lottie files, but converting it to ReactXP would be a quick and easy task.

Packaging in storybook still solves the cross platform requirement.

• Add a circleci minimal build

Getting above mentioned error on android. Can you rectify or advice.

It would help TypeScript users and the adoption of this module, to add the typing file to DefinitelyTyped.

Here is the typing file I've implemented and am using in a real app now:

declare module "lottie-reactxp" {

  import * as React from "react";

  export interface ILottieProps {
    source: object;
    loop?: boolean;
    isStopped?: boolean;
    duration?: number;
    width?: number;
    height?: number;
    style?: object;
    onComplete?: () => void;
    onLoopComplete?: () => void;
  }

  class Lottie extends React.Component<ILottieProps, any> {}

  export default Lottie;

}

This module needs to publish correctly to NPM. Currently it omits required files.

Seeing as ReactXP is targetting browser and native, I think it makes sense to ship transpiled module on native also.

facebook/react-native#7850
https://stackoverflow.com/questions/37277215/transpile-react-native-module-to-es5-before-publishing-to-npm

Need to figure out whether this has implications on an upgrade path. I dont believe it does.

Some of the information is wrong.

• developer setup does not need to configure Lottie native

• general usage setup does.

Ive made changes.

Release to NPM once its confirmed that React Native is fine with using a pre-transpiled version of this library.

Bodymovin JS API for web has event hooks to notify when a animation cycle has completed.

Implementing these hooks on both Web and Native would be useful.