Git Product home page Git Product logo

itunes_transporter_generator's People

Contributors

colinhumber avatar girasquid avatar linjunpop avatar mmacvicar avatar rromanchuk avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

itunes_transporter_generator's Issues

Images with the same filename result in a single final image.

For example, if we set an english screenshot with filename "en/screenshot.png" and a german screenshot named "de/screenshot.png", in the resulting .itmsp only 1 image file will exist "1.png", even if the 2 original images are different.

In order to get the correct result "--prefix-images" must be specified.

Running the example generates error since review_notes are empty

When verifying you get this error:

ERROR ITMS-3000: "Line 23 column 26: character content of element "review_notes" invalid; must be a string with length at least 2 (actual length was 0) at XPath /package/software/software_metadata/in_app_purchases/family/review_notes"

Using a numeric only vendor_id results in error

The iTunes metadata spec permits alphanumeric vendor_id values, including numeric only values:
"The vendor identifier can only contain alphanumeric characters and underscore marks; it cannot contain spaces, dashes, ampersands, other punctuation, or symbols. The vendor identifier is case-sensitive and must not start with an underscore. If a Vendor ID is numeric, it is treated as a string, not numbers; a vendor identifier of '00000000012345' is not the same as '12345'"

However, if you use the following example ID for the field:
vendor_id: 80658

Then the following error is thrown:
error: String can't be coerced into Fixnum. Use --trace to view backtrace

If you add ANY letter to the field, e.g.:
vendor_id: 80658a

Then it works perfectly - the error seems to indicate that it's trying to convert something which should always remain a string into another type..

Don't prefix screenshot filenames

Need a way to tell the app not to change the screenshot filenames. I already generate my png's in their final format, for example.

iphone_4in:
- 'Spanish_lite_zh-Hans_iphone4_4in_retina_pictures.png'
- 'Spanish_lite_zh-Hans_iphone4_4in_retina_word_search.png'
- 'Spanish_lite_zh-Hans_iphone4_4in_retina_concentration.png'
- 'Spanish_lite_zh-Hans_iphone4_4in_retina_StudyDetail.png'
- 'Spanish_lite_zh-Hans_iphone4_4in_retina_hangman.png'
iphone_3.5in:
- 'Spanish_lite_zh-Hans_iphone35_retina_pictures.png'
- 'Spanish_lite_zh-Hans_iphone35_retina_word_search.png'
- 'Spanish_lite_zh-Hans_iphone35_retina_concentration.png'
- 'Spanish_lite_zh-Hans_iphone35_retina_StudyDetail.png'
- 'Spanish_lite_zh-Hans_iphone35_retina_hangman.png'
ipad:
- 'Spanish_lite_zh-Hans_ipad_retina_pictures.png'
- 'Spanish_lite_zh-Hans_ipad_retina_Home.png'
- 'Spanish_lite_zh-Hans_ipad_retina_word_search.png'
- 'Spanish_lite_zh-Hans_ipad_retina_concentration.png'
- 'Spanish_lite_zh-Hans_ipad_retina_StudyDetail.png'

Automatically generate YAML file from external localizations

We allow people to translate our App Store listing into their local language via Transifex: https://www.transifex.com/projects/p/chatsecure/

It looks like we will need to write another script that pulls in the localizations and loops through them to generate this YAML file. When you have 20+ languages it becomes painful to craft even these files by hand, as I'm sure you know.

I'll update this issue with a link to a script or a pull request when we figure it out.

RubyGems Version Different?

It looks like the RubyGems version is at 0.37, but I only see 0.36 here on GitHub. Are you going to push that version here as well?

Update docs to reflect ability to update version-level localized screenshots and metadata

The README.md doesn't reference the ability to edit version-level localized screenshots and metadata supported in the new version of Transporter, but it looks like you support it from the example YAML and XML files.

XML Feed
Existing
• In-app purchases
    <in_app_purchases> ... </in_app_purchases>
• Game Center Leaderboards
    <leaderboards> ... </leaderboards>
• Game Center Achievements
    <achievements> ... </achievements>

New
• Version - level localization
   <versions> ... </versions>
• Pricing and availability
    <products> ... </products>
• In-app purchases - hosted content support
    <in_app_purchases>
        ...
        <has_hosted_content> ... </has_hosted_content>
        <software_assets> ... </software_assets>
    </in_app_purchases>

Feature Request: i18n style string files

It would be nice if you could format this into a standard i18n yaml strings file, and then export to itunes xml style. That way, for people using translation services, can easily integrate this into their workflow

File size of itms file is huge

Hey,

just a question: In a previous version the screenshots were only saved once in the itmsp file. In the new version (0.4.6.) for every language the screenshots get saved separately which blows up the size of the itmsp file.
Is there a way to avoid creating screenshot files for all localizations (my screenshots are the same for all languages)?

Thank you

Screenshots Positions

If you add 5 screenshots for all three devices, it's numbered 1-15 in the xml, but iTunes wants them to have the positions 1 through 5.
So the coolest solution would be, that it sets the positions within each display_target.

License missing from gemspec

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can imagine, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post about this project for more information.

Localization for finnish (fi-fi) incorrect

Hey,

when I create the yaml file and enter content for the fi-fi localization, this data does not show up in the itmsp file. Instead for the fi-fi localization the fr-fr data shows up in the itmsp file.
I can send you sample data if that helps. All other localizations work fine for me.

Thanks for looking into this!

Philipp

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.