coleturner / graphql-rails-resolver Goto Github PK

Hi there,

Great little gem, thanks for this!

I think the where param is broken in the current implementation. In the docs the example

resolve :createdAt, :where => :created_at

should result in the GraphQL argument createdAt being mapped to the model's created_at field. However, the particular line of code that would do this (https://github.com/colepatrickturner/graphql-rails-resolver/blob/master/lib/graphql/rails/resolver.rb#L89) is never reached because of the params.size < 1 check a bit further up (https://github.com/colepatrickturner/graphql-rails-resolver/blob/master/lib/graphql/rails/resolver.rb#L77). Probably just a glitch due to some refactoring.

I didn't create a pull request though because I am not sure how that params size check was originally intended.

Cheers,
-Jonas

This is an awesome looking gem, and I think it solves one of my main issues with how graphql-ruby works. Namely, the QueryType gets very big very fast, and a lot of the logic is really just wrappers around built-in rails logic.

Two questions:

1. It looks like the gem hasn't been updated since 2017. Is it still active, or should I avoid using it?
2. I'm not sure if graphql-ruby resolvers got added after this gem or what, but it feels like this gem should be updated to use resolvers, since using resolve seems to be discouraged at this point.

I have been struggling to get this to work in my current app. I have no Idea how to reference the resolver-class. This plugin needs a getting-started doc