rosetta-cli check with --lookup-balance-block=false doesn't find reconciliation errors unless --interesting-accounts is given about mesh-sdk-go HOT 1 CLOSED

Thanks for posting this issue @metajack! You found a very annoying bug that only affects check when --lookup-balance-by-block=false.

This issue can occur if an account (in this case, ones that have reconciliation issues) are skipped while check is catching up to tip and never show up in blocks again.

When accounts are skipped, they are not added to the inactive reconciliation queue (either initially or when taken from the inactive queue 😬 ): https://github.com/coinbase/rosetta-sdk-go/blob/6fcf086bc01df22380c3809332641cb870683d9b/reconciler/reconciler.go#L446-L456

This behavior also occurs if we are less than the highWaterMark: https://github.com/coinbase/rosetta-sdk-go/blob/6fcf086bc01df22380c3809332641cb870683d9b/reconciler/reconciler.go#L275-L277

We will work a fix in for this very soon!

from mesh-sdk-go.