Git Product home page Git Product logo

Comments (6)

GeekArthur avatar GeekArthur commented on June 20, 2024 2

@rllola You are correct, the current rosetta-cli 0.10.0 doesn't consume the latest rosetta-sdk-go which includes the check:spec fix. Given currently check:spec is not the mandatory requirement of rosetta implementation, so I didn't create the releases for both rosetta-cli and rosetta-sdk-go immediately to accommodate the release schedule for other features/fixes, but I will wait for 2 more days, if nothing else needs to deliver I will create a patch release this Friday only for check:spec fix

from mesh-sdk-go.

GeekArthur avatar GeekArthur commented on June 20, 2024 2

Release v0.8.2 is published

from mesh-sdk-go.

GeekArthur avatar GeekArthur commented on June 20, 2024

Yes, we will create releases for both Rosetta CLI and Rosetta SDK soon, usually the releases will be created monthly

from mesh-sdk-go.

rllola avatar rllola commented on June 20, 2024

Hey @GeekArthur

I noticed in Rosetta CLI you added the check when no hash or index are specified in the partial block identifier. However because Rosetta CLI is using rosetta-sdk-go v0.8.1 it doesn't include the commit e03849b

Because of that check:spec will always fail.

see the piece of code in v0.10.0
https://github.com/coinbase/rosetta-cli/blob/v0.10.0/cmd/check_spec.go#L306-L313

A release for rosetta-sdk-go and updating it in rosetta cli will fix it. Do you think it would be possible to make an early release just to fix that ? It would avoid us having to have our own fork until it is fixed.

from mesh-sdk-go.

rllola avatar rllola commented on June 20, 2024

@GeekArthur Any news about the release ?

from mesh-sdk-go.

tac0turtle avatar tac0turtle commented on June 20, 2024

pinging about this, it would help us avoid a replace tag in our and our users go.mods

from mesh-sdk-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.