coi-dev / flutter-deltachat-core Goto Github PK

The current code is still based on the previous Git setup. To be able to build the plugin it must be adjusted. Also some of the documentation needs to get adjusted (fix links and change build instructions).

Describe the Problem
We should remove https://github.com/open-xchange/flutter-deltachat-core/blob/develop/ios/Libraries/libdeltachat.a from the repository and also from the history to reduce the overall size when cloning.
Some tooling exists to perform this task https://help.github.com/en/github/authenticating-to-github/removing-sensitive-data-from-a-repository
It should also be added to the .gitignore file.

Describe the bug
Due to the current architecture there is the small chance that events emitted by the DeltaChatCore aren't delegated to the Flutter plugin. The native implementation is getting the events from the DCC without problems.

To Reproduce
Occurrence: [rarely]
Steps to reproduce the behavior:

1. Perform an action which executes a DCC command and creates a new event listener right after (e.g. sending a message, which creates a listener for state changes [sent, read])

Expected behavior
All events are delegated to the Flutter plugin.

Additional context
Error case flow:

1. Action is executed
2. Listener registration is started (this could take a short amount of time)
3. Event is fired
4. Listener registration is finished
5. Event is lost

Even if we register the listener in before, as the register call is asynchronous there can always be bad timing and lost events. This line https://github.com/open-xchange/flutter-deltachat-core/blob/develop/android/src/main/java/com/openxchange/deltachatcore/handlers/EventChannelHandler.java#L68 filters events if no listener exists.

Internal bug tracker (Android)
Internal bug tracker (iOS)

Is your feature request related to a problem? Please describe.
Currently import / export keys is only supported by the Android part of the plugin, please add iOS support.

Describe the solution you'd like
The following flow happens on Android and should be similar on iOS:

• https://github.com/open-xchange/flutter-deltachat-core/blob/aeaa07095007e522dc2dad957ad2221d8bf7f299/lib/src/context.dart#L265
• https://github.com/open-xchange/flutter-deltachat-core/blob/54770944a4f66a979577b80566826e03b154f764/android/src/main/java/com/openxchange/deltachatcore/handlers/ContextCallHandler.java#L741

Internal bug tracker

Describe the bug
Due to problems with the used PGP library we are currently unable to build a well working Android version. This issue blocks a new release for the Android version. The symptom of this problem is a bricked app, as soon as a file is received.

Additional context
To fix this we will apply a temporary fix in our build script, which changes the PGP dependency on the fly, until the problem itself is fixed.

Is your feature request related to a problem? Please describe.
We should use Android embedding v2, as this could improve stability.

Describe the solution you'd like
Ẃe should follow the official documentation

The documentation should be moved to Github, so everything is gathered and accessible at one place.

Is your feature request related to a problem? Please describe.
We should switch to https://github.com/open-xchange/deltachat-core as we want to try the new features / changes prior upstream merge.

Additional context

• We still need some kind of fixed versioning, to avoid API conflicts.

Update to DCC https://github.com/deltachat/deltachat-core/releases/tag/v0.41.0

Internal bug tracker

Description
When importing the address book the app stuck on the progress overlay. There isn't any progress visible, but the contacts are imported. Overlay doesn't disappear which results in an overall blocked UI.

Tested on

• Simulator: iPhone 8, iPhone XR and iPhone XS
• Device: iPhone 7
• OS: iOS 12.4, iOS 13.1

Internal Bugtracker

Is your feature request related to a problem? Please describe.
We currently have multiple sub repositories for the DCC and also multiple build scripts for the platforms. We have to merge those.

Describe the solution you'd like

• One build script, located in the project root
• One command, with parameters if required, to build the whole DCC. This includes copying the files to the required folders for both projects
• One import of the sub repository

Internal bug tracker

Describe the bug
When a message gets flagged/unflagged a yellow star should appear/disappear. This already happens on restarting the app.

To Reproduce
Occurrence: [always]
Steps to reproduce the behavior:

1. Start the app
2. open a chat
3. long press an unflagged message
4. from context menu select "Flag/Unflag"

Expected behavior
A yellow star should appear next to the message.

Screenshots

Internal Bugtracker

Is your feature request related to a problem? Please describe.
We should update our build tools, wrapper components, fix lint issues and similar stuff.

Describe the solution you'd like
Make sure that the methods to set and get the duration are in the iOS classes.
For the Dc_Msg add:

• DcMsg_getDuration

and for the context_createChatAttachmentMessage add setDuration(duration) for the new DcMsg.
Android part:

DcMsg newMsg = new DcMsg(dcContext, type);
newMsg.setFile(path, mimeType);
newMsg.setText(text);
newMsg.setDuration(duration);
int messageId = dcContext.sendMsg(chatId, newMsg);

Internal Bug Tracker

Is your feature request related to a problem? Please describe.

• We are now able to use NDK version 19 (fc16219) and the documentation should get updated

Internal bug tracker