Git Product home page Git Product logo

bookrev-lite's People

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bookrev-lite's Issues

Wrong assigned color

image

The highlight of the day background color is being pulled from the articles background color

Theme Review

  • Remove hardcoded meta tags from header.php
  • Use add_support for title.
  • Enqueue htmlshiv from functions.php.
  • Only load pingbacks when needed,
  • Replace favicon control with the core control.
  • Replace logo with core function.
  • Escape tags.
  • Make sure everything is prefixed.
  • Remove prefixed from third party resources.
  • Remove book_rev_lite_sanitize_hex function.
  • Use HTML equivalent of ... in excerpt filter.
  • Adjust content-width based on page type.
  • Remove the unused author template.
  • Remove/replace $post->id with get_the_ID.
  • Don't load /includes/plugin.php
  • Update theme tags.
  • After finish dealing with all the above, do a proper review to see debug logs.

pb wp.org

@rodica-andronache aici mai sunt niste probleme, de ex imaginile din screenshot nu sunt ok si poate alte chestii, ar fi super sa faci o verificare si sa trimiti un update.

Text domain tre sa fie : book-rev-lite similar cu slug-ul

Change type of control to number

Appearance > Customize > Main Page > Latest Articles Block - Article Count control accepts text when it should only accept numbers. So, we need to change that control to a number type control.

Issue With The Slider Image

The slider on the top picks the product image (WP Product Review plugin) for the thumbnail. If the post has no product image then it didn't check for the featured image, but uses the default image instead. So it should check for the Featured Image before using the default image.

@ineagu Pull request is on the way. ;)

[wp.org review]Escaping

Please have one separate commit for each of this tasks to be easier to check:

  • Escaping missing in footer.php L77
  • Escaping missing in bookrev_slider_template.php L9
  • book_rev_lite_wpr_get_title() function is returning raw value from database. So, its output should be escaped when displaying. When calling the function, please get the value in a variable. And then, escape that variable when echo-ing it
  • Value from get_permalink() should be escaped with esc_url() when used in href attribute.
  • Please implement proper sanitization in the functions like bookrev_lite_sanitize_notes(), book_rev_lite_sanitize_dropdown(), book_rev_lite_sanitize_radio().

wp.org review

Security
Please implement proper sanitization in the functions like bookrev_lite_sanitize_notes(), book_rev_lite_sanitize_dropdown(), book_rev_lite_sanitize_radio().
Escaping missing in footer.php L77
Escaping missing in bookrev_slider_template.php L9
book_rev_lite_wpr_get_title() function is returning raw value from database. So, its output should be escaped when displaying.
Value from get_permalink() should be escaped with esc_url() when used in href attribute.
WordPress Functions
You can now remove book_rev_lite_numeric_pagination() and use the_posts_pagination() instead.
Upselling
Only one button is allowed in Customizer. But injecting HTML through JS is not allowed. You can use this as reference. https://github.com/justintadlock/trt-customizer-pro

https://themes.trac.wordpress.org/ticket/37520

Yoast SEO bug

Your theme contains a meta description, which blocks Yoast SEO from working properly, please delete the following line, or press fix it:
<meta name="description" content="">`

Slider Speed

We have a message from a client. "Any way to adjust the slider speed?"

At the moment we do not have this possibility. I think it's a good idea to integrate this feature. @vncatalin @ineagu

Review Button

La fel cum ai adaugat butoanele cu documentatie si pro, adauga un buton cu textul: "Leave a review ( it will help us )", daca este prea lung scoate paranteza, si cu link catre pagina de review a fiecarei teme ( https://wordpress.org/support/view/theme-reviews/zerif-lite ) de pe wordpress.org. Gasesti aici temele: https://profiles.wordpress.org/codeinwp .

In functie de tema unde este adaugat acest issue, cauti tema in directorul wp si gasesti link-ul de review. Pentru temele care nu sunt inca in director nu adaugi butonul dar lasi issue deschis pentru a fi adaugat cand este tema in director.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.