image URL is double encoded about contao-social_images HOT 8 CLOSED

Yeah, I'll debug :)

from contao-social_images.

3.5.3 is released now.

from contao-social_images.

Hm I have set up the filename as you suggested but it seems to work fine for me:

<meta property="og:image" content="http://tmp:8888/files/test/FALTER_Scheck%C3%BCbergabe%202018%20%28c%29%20Karin%20Wasner.jpg">

Can you find out which module includes this image (core, news, etc.) ?

from contao-social_images.

It's from a news list (image of the first news in the list on that page).

from contao-social_images.

I am still unable to reproduce that on MacOS 🙈 can you find out the fix for yourself?

Is the image size calculated correctly? If it's double encoded then it should not work either...

from contao-social_images.

Ah, you need to set an image size in the page layout for the social images. \Image::get already encodes the image path. That's why it gets double encoded (even when it's not actually resized of course).

from contao-social_images.

I'd propose the following:

    // Resize the image
    if ($resize[0] || $resize[1] || $resize[2]) {
-       $strImage = \Image::get($strImage, $resize[0], $resize[1], $resize[2]);
+       $strImage = urldecode(\Image::get($strImage, $resize[0], $resize[1], $resize[2]));
-       list($width, $height) = getimagesize(TL_ROOT . '/' . urldecode($strImage));
+       list($width, $height) = getimagesize(TL_ROOT . '/' . $strImage);
    }

from contao-social_images.

I was about to write exactly the same. Thanks, I will fix this soon!

from contao-social_images.