Git Product home page Git Product logo

Comments (11)

qzminski avatar qzminski commented on June 17, 2024 1

Implemented in d177f82 but this can produce unexpected results because of contao/core-bundle#1214.

from contao-social_images.

qzminski avatar qzminski commented on June 17, 2024

Note: I realize your extension allows for more than one og:image to be present for legacy reasons. May be this feature should be dropped? I don't think there is any reason anymore to have more than one og:image defined.

I think it's mostly there to give the user a choice which image he would like to use. Would it harm if we add og:image:width and og:image:height to all images?

from contao-social_images.

fritzmg avatar fritzmg commented on June 17, 2024

I think it's mostly there to give the user a choice which image he would like to use.

Well, where can you do that? Facebook for instance does not offer to switch through multiple share images, when sharing a post.

Would it harm if we add og:image:width and og:image:height to all images?

I suppose not - though it would generate a lot of additional markup. Also, how would you be able to identify which og:image:width belongs to which og:image?

from contao-social_images.

qzminski avatar qzminski commented on June 17, 2024

Well, where can you do that? Facebook for instance does not offer to switch through multiple share images, when sharing a post.

This must have changed because at the time I developed this extension it was possible. Or was it another service... 🤔

I suppose not - though it would generate a lot of additional markup. Also, how would you be able to identify which og:image:width belongs to which og:image?

Just like a regular array: http://ogp.me/#array

from contao-social_images.

fritzmg avatar fritzmg commented on June 17, 2024

This must have changed because at the time I developed this extension it was possible. Or was it another service... 🤔

Yeah, it was possible in the past. That's why I said "for legacy reasons" ;)

from contao-social_images.

qzminski avatar qzminski commented on June 17, 2024

I would preserve the multiple selection of images as the OpenGraph protocol is not a Facebook protocol and other services are potentially making use of those arrays. Agreed?

from contao-social_images.

fritzmg avatar fritzmg commented on June 17, 2024

Agreed.

from contao-social_images.

fritzmg avatar fritzmg commented on June 17, 2024

Yeah, see the comments though: you should just combine each og:image/og:image:width/og:image:height combo into one string.

from contao-social_images.

qzminski avatar qzminski commented on June 17, 2024

The 3223cd7 should do then.

from contao-social_images.

madmaharaja avatar madmaharaja commented on June 17, 2024

This must have changed because at the time I developed this extension it was possible. Or was it another service... 🤔

Yeah, it was possible in the past. That's why I said "for legacy reasons" ;)

Just bumped into this thread because I was looking for a way to add og:image:width and og:image:height to my page templates in Contao. Anyway, just for the record: It is still (or again?) possible to switch through and select from multiple ogimage files when sharing a URL on Facebook.

from contao-social_images.

fritzmg avatar fritzmg commented on June 17, 2024

Yeah, I also noticed that this feature has returned on Facebook.

from contao-social_images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.