constructor(nonce: U256, fee: U256, networkId: number, action: Action)

=> constructor({ nonce: U256, fee: U256, networkId: number, action: Action})

blocked-by-codechain

Pay to Public Key Hash: VERIFY opcode needed

$ yarn build

yarn run v1.7.0
$ rollup -c rollup.config.ts

src/index.ts → ./lib/index.js...
[!] (rpt2 plugin) Error: /home/sgkim126/workspace/codechain-sdk-js/src/index.ts(231,5): semantic error TS4026 Public static property 'signEcdsa' of exported class has or is using name 'ECDSASignature' from external module

getBlock(blockNumber: number): Block

StandardAssetAgent is same as PubkeyAssetAgent(#44) except that StandardAssetAgent understands standard scripts but not pubkey script.

Library should not keep yarn.lock file in the repo.

https://github.com/feross/buffer or change implementation

• RPC supported
• Add connect (...)
• Add disconnect (...)
• Add shareSecret (...)

Could you give me a sample code?

• Payment action (recipient)
• createAssetScheme (registrar)

We need a high-level script language that is similar to Ivy for ease of writing scripts.

README

• Add ToC
• Add print result for console.log in the example

Code base

• Rename from Address to AccountId
• Import Bech32

Platform Account Address

• PlatformAccountAddress primitive
• SDK.sendCCC = ({ account id, amount }) => Parcel with payment action
• ...

Asset Transfer Address

• AssetTransferAddress primitive
• Asset.transfer = ({address, amount}[]) => AssetTransferTransaction
• AssetScheme.mint = ({address, amount}) => AssetMintTransaction
• ...

Currently:

class AssetTransferInput {
    lockScript: Buffer;
    unlockScript: Buffer;
    ...
}

Patch:

class AssetTransferInput {
    lockScript: Script;
    unlockScript: Script;
    ....
}

• Buffer (#62)
• Bundle

• AssetData
• AssetOutPointData
• AssetTransferInputData
• AssetTransferOutputData
• AssetTransferTransactionData
• ...

• rpc
  • node
    • ping
    • getNodeVersion
  • chain
    • sendSignedParcel
    • getParcel
    • getParcelInvoice
    • getRegularKey
    • getTransactionInvoice
    • getBalance
    • getNonce
    • getBestBlockNumber
    • getBestBlockId
    • getBlockHash
    • getBlock
    • getAssetScheme
    • getAsset
    • getPendingParcels
  • network
    • shareSecret
    • connect
• core
  • createPaymentParcel
  • createSetRegularKeyParcel
  • createChangeShardStateParcel

    Parcel.sign

  • createCreateShardParcel
  • getAssetAgent

    AssetAgent.createAddress

  • createAssetScheme

    AssetScheme.mint

  • createAssetMintTransaction (not implemented)
  • AssetMintTransaction.getMintedAsset (not implemented)

    Asset.transfer

  • createAssetTransferTransaction (not implemented)
  • createAssetTransferInput (not implemented)
  • createAssetTransferOutput (not implemented)
  • AssetTransferTransaction.getOutputAssets (not implemented)
• util
  • toHex
  • blake256
  • blake256WithKey
  • ripemd160
  • signEcdsa
  • verifyEcdsa
  • recoverEcdsa <- (기존 recoverPublic)
  • generatePrivateKey
  • getAccountIdFromPrivate <- (기존 privateKeyToAddress)
  • getPublicFromPrivate <- (기존 privateKeyToPublic)

getAssetScheme() gets the asset scheme from the latest state only.
Since asset scheme is a part of the blockchain state, it should be able to get an asset scheme from the specific state.

Currently, the below example doesn't work

let sdk = new SDK(...);
let { getBlock, ... } = sdk.rpc.chain;

getBlock("0x123..").then(...)

Because of the function context.

Changing all the functions to the arrow function is one of the solutions.

Depends on CodeChain-io/codechain#252

Add

• Features
• How to install
• Documentation

Current:

new SDK("http://localhost:8080")

Patch:

new SDK({
  url: "http://localhost:8080",
  networkId: 0xCA
})

Currently, the network id in the Parcel or Address are not validated and not auto-filled because of that SDK doesn't know what is decent.

getAsset() gets the asset from the latest state only.
Since asset is a part of the blockchain state, it should be gettable from the specific state.

See getBalance and getNonce which already have the optional block number param.

I'd like to use defined "Block" type for DB document type. And I need "Hash" value for searching transaction by hash key.

Currently, a user must run yarn build before running integration tests, since yarn test-int doesn't build the source.

PubkeyAssetAgent

• manages the map(lockScriptHash -> Public Key)
• understands "PubKey" script (PUSH <pubkey> CHKSIG)

Current foramt is

    "transactions":[{
      "payment":{
        "nonce":"0x1",
        "receiver":"0xa6594b7196808d161b6fb137e781abbc251385d9",
        "sender":"0xa6594b7196808d161b6fb137e781abbc251385d9",
        "value":"0x0"
      }
    }]

Modify it to

    "transactions":[{
      "type": "payment",
      "data":{
        "nonce":"0x1",
        "receiver":"0xa6594b7196808d161b6fb137e781abbc251385d9",
        "sender":"0xa6594b7196808d161b6fb137e781abbc251385d9",
        "value":"0x0"
      }
    }],

• getNodeInfo = () => Promise<NodeInfo>

Current:

var myAsset = ...
var transferTransaction = myAsset.transfer([{
    address: addressAlice
    amount: 10
}, {
    address: addressBob
    amount: 20
}])

Proposal:

var myAsset = ...
var transferTransaction = myAsset.createTransferTransaction({
    recipients: [{
        address: addressAlice
        amount: 10
    }, {
        address: addressBob
        amount: 20
    }]
})

Currently, editor doesn't show errors when

• Missing semicolon exists
• Calling a private constructor
• ...

Use ISC license.

Currently, the parcel creation could be done by below:

const SDK = require("codechain-sdk");
const { Parcel } = SDK;

const fee = new U256(10);
...
const parcel = new Parcel(fee, nonce, networkId, ...);
parcel.sign(...)
...

But, the current has some issues:

• Exposing a bunch of classes and using it directly is not natural nor intuitive.
• SDK could not have contexts such as network id or default value for a fee, etc.

So it needs to be changed with some principles

• SDK do not expose classes unless it's necessary.
• Every parameter which has the type of primitive classes(U256, H160) must be substitutable with JS primitive types.

Renewaled:

const SDK = require("codechain-sdk");
const sdk = new SDK({ networkId: 0xCA, ... });

const parcel = sdk.createParcel({ fee: 10, nonce: 10, ... })
parcel.sign(...)
...

• Add Parcel-related methods
• Add Address-related methods
• Do not expose the classes
• Keep parameter consistency
• Update examples
• Improve typedoc readability

Module Splitting #53

Current:

...
var myAddress = ...
var myAsset = sdk.core.createAsset({ metadata, registrar, amount })
var mintTransaction = myAsset.mint(myAddress)

Proposal:

...
var myAddress = ...
var myAssetScheme = sdk.core.createAssetScheme({ metadata, registrar, amount })
var mintTransaction = myAssetScheme.createMintTransaction({ recipient: myAddress })

Method

• getKeyList()
• createKey(password?) => H512
• removeKey(password) => void
• sign({ key, message, password? }) => H520

Until codechain support it, SDK will implement and use SecretStoreMemory which is not persistent.

getParcelInvoice/getTransactionInvoice send a RPC request repeatedly until timeout.

But, currently, the request is not aborted. So if the request takes 10 seconds when given timeout is 5 seconds, the method takes 10 seconds. It should be aborted at the moment of the timeout.

I think sendRpcRequest should support a timeout option.
https://github.com/tedeh/jayson#client-interface-description