• Added toString() for Hxxx classes
• Added toJSON() for Uxxx and Hxxx classes
• Added zero() for Hxxx classes

When the length of rlp encoded U64, U128, U256 value is one (e.g. 1 for Buffer [0x01]), the decoding does not work. The decoding is based on the assumption that the length padding comes in the first bytes of the encoded array. But that's not the case when the encoded number has a value smaller than 256.

#68 is fixed, but the current implementation requires the users to turn on allowSyntheticDefaultImports in their typescript configuration.
The root cause of the problem is the weird typescript behavior on bn.js, so it'd be better to just ignore its type definitions.

Current To-do

• Define SchnorrSignature interface in key.ts
• Define signSchnorr, verifySchnorr, recoverSchnorr functions in key.ts
• Split key.ts
• Add test cases on Schnorr signatures

• toString(): string
  The string is a hex string without 0x prefix.

• toJSON(): string
  The string is a hex string with 0x prefix. CodeChain JSON-RPC server only accepts 0x prefixed hex string.

It's unnatural and make people get confused

Example

const n = new U64(1000000);
console.log(n.toLocaleString()); // 1,000,000

When I try to import this library in typescript, I get the following error:

error TS7016: Could not find a declaration file for module 'bn.js'. '.../node_modules/bn.js/lib/bn.js' implicitly has an 'any' type.
  Try `npm install @types/bn.js` if it exists or add a new declaration (.d.ts) file containing `declare module 'bn.js';`

1 import BN = require("bn.js");

https://codecov.io/gh/Codechain-io/codechain-primitives-js/tree/master/src/value

-> expect fromBytes ... [0x96, 0x10, ...] to equal new H128("0x10...")

-> expect to throw: new U64(new BigNumber("0xFFF....FFF"))

-> expect to be false: U64.check(new BigNumber("-1")) ...

For consistency with others, toJSON() should be added to the address types.

Because the logic of PlatformAddress.check is different from PlatformAddress.fromString, check returns true for the invalid string.
For example, cccqgfrg4ncjqfrg4ncjqfrg4ncjqfrg4ncjq2tpqzg is not a valid platform address because the version is 2, but check returns true.

It seems that there exists a script for testing this project.
But there is no mention about testing in the REMDME.md.