code4romania / monitorizare-vot-ong Goto Github PK

Consideram ca primim din token-ul JWT si informatiile
{idONG}

Filtru (din model) contine :
public int Page { get; set; }
public int PageSize { get; set; }

Pentru

• Top sesizari / judete
• Top sesizari / sectii
• Top sesizari la deschidere (A) / judete
• Top sesizari la numarare (C) / judete
• Top numar de observatori / judete

Executare raw sql query-uri pentru a face GROUP BY in BD, si nu in memorie.

Filtrare statistici dupa IdONG

Our data team has said that pivoting every time the RawResults xlsx available on https://code4.ro/en/project/monitorizare-vot/ is too much work. They would need a csv export with:

• each row is an observation (one polling station, one observer)
• each column is a question/answer (along all forms)
• export notes together with answers (to be clarified how)

Remove the hardcoding of the form codes - use the FormVersions api to get the available forms, then populate the local store.

API

• add a call to retrieve available forms
• add call info in swagger docs

Frontend

• display available forms
• for each form display code, name and action buttons for viewing, editing and deleting a form
• screen mockups available here: http://bit.ly/2L0tNG2

Best practices

• codebase language should be English
• we 💕 unit tests

• API subtask: create a new API endpoint /api/v1/formulare/meta that return the name of the available form (form code), the description (form description) and if the form is completed or draft (form completed flag)
• Frontend subtask: display the available forms, their state and actions pertaining for each form, as per the screen mockups

API

• add a call to delete question from form
• add call info in swagger docs

Frontend

• implement a way to delete questions from forms

Best practices

• codebase language should be English

• we 💕 unit tests

• FE: implement a delete button for questions on forms panel along with delete functionality

• BE: enhance forms controller to accept a delete operation on a question of a form

Would be very cool and allow observer core team to see how will it look in the app. Are some questions not mandatory. Is it better to frame sth as a seprate question, as a extra answer within the options or as an ask to add a note.

• define forms
• export forms in Word document (so paper forms can be handed-in as well to observers that will correspond 1-to-1 to app forms)

Sometimes observers pass information to coordinators through other channels than the app. Coordinators should be able to input notes / photos on behalf of the teams.

API

• add a call to mark question as read flag
• add call info in swagger docs

Frontend

• a checkbox should be available for each question in order to mark it as red flag
• screen mockups available here: http://bit.ly/2L0tNG2

Best practices

• codebase language should be English

• we 💕 unit tests

• FE: add a red flag marker for a specific option on a question in frontend

• BE: enhance forms controller to accept red flag indicator as part of the model received from frontend

Running in . and .\frontend

> ng serve
Local workspace file ('angular.json') could not be found.
Error: Local workspace file ('angular.json') could not be found.

Problem: Notes are not possible to process automatically. To make sense of them they need to be somehow processed for further analysis. Our analysts (2 of them) were going through all the notes tagging them. As they have been working on semi-incremental exports they might have analyse same notes twice. It was also hard to then analyze those notes in total.

I propose to move this annotation process into the platform. That would look as following:

• notifications / list of new unprocessed notes
• possibly filtering nodes by modulo of number of people analyzing them so same note won't be processed by many people
• each note will be shown with photo / video next to it and also the linked question and answer
• analysts will be able to add free-form tags to each note
• while adding tags the ones already existing will be auto-suggested
• list of all the notes filtered by question, tag, person/team
• nice-to-have: ability to merge tags
• simple statistics based on tags, questions, polling stations

500 thrown by https://mvngo.azurewebsites.net/api/v1/raspunsuri?page=1&pageSize=5&urgent=true
translate/entities branch

API

• add a call to add a new question to the form
• add call info in swagger docs

Frontend

• a wizard similar to Google forms - view moqups here https://www.figma.com/file/61NHR7fwmV1Dsv4Pb6F8T7/code4ro_mv_user-management_2018.04.21-Copy?node-id=97%3A1639
• every question receives an unique ID made of the Form ID and the form section it is in (eg: Formular A + Sectiune B + nr intrebare = A-B.1 or something like that)

Best practices

• codebase language should be English
• we 💕 unit tests

• API task: enhance API with new endpoint - /api/v1/formular/{cod_formular}/intrebare where you can POST with a Question that will be added to the Form
• Frontend task - add a frontend placeholder for inserting a new question and adding it to the form

Adaugare model raspuns paginare

Includerea campului de Total in modelul de Paginare existent.

Util pentru utilizarea modelului in raspunsuri de la server catre client.

• returneaza rezultate dublate sau gruparea nu se face corect
  (ex: AR apare de doua ori AR-4 si AR-16)

Filtru (din model) contine :

• public int IdSectieDeVotare { get; set; }
• public int IdObservator { get; set; }

Returneaza raspunsurile date pe baza id-ului observatorului si id-ului sectiei de votare.

API

• add a call to add a new form
• add call info in swagger docs

Frontend

• display a button in the form set screen for adding a new form
• implement screen for adding the information about the new form
• a form can contain multiple types of questions
• here is a link to the real forms for real examples of questions and types of questions https://docs.google.com/spreadsheets/d/1kAhpqSu0bhEfxH0l0nWTOX0AlPcK_VXQbuDsj35WzL8/edit#gid=0
• screen mockups available here: http://bit.ly/2L0tNG2

Best practices

• codebase language should be English
• we 💕 unit tests

• API task - add a POST to formular API to save a new form in the backend
• Frontend task - add a new page for creating and saving a form

Guys, aveti idee ce sa fac ca sa rulez proiectul local ?

Eroare pe care o primesc Format of the initialization string does not conform to specification starting at index 0. in RaspunsuriQueryHandler la linia 26, variabila sectiiCuObservatori are pe Results Views o expectie cu acest mesaj

API

• add a call to update question on form
• add call info in swagger docs

Frontend

• display question data
• implement a wizard similar to google form for editing question data
• just like in Google forms, if you are in edit mode on a form, everything can be edited at any moment, there is no edit button per question

Best practices

• codebase language should be English
• we 💕 unit tests

Tasks:

• FE: implement functionality of editing questions and options on forms
• BE: implement functionality of accepting PUT operations on questions

So observers don't see what are they typing into.

I'm not sure was it related with notes or extra text answers.

Consideram ca primim din token-ul JWT si informatiile
{idONG}

Filtru (din model) contine :
public int Page { get; set; }
public int PageSize { get; set; }
public bool Urgent { get; set; }

Trebuie adusa o lista cu toate sectiile de votare [tabela:SectieDeVotare] la care au raspuns observatorii [tabela:Observator] ce tin de {idOng} care au raspuns la intrebarile din formulare [tabela:Raspuns] marcate cu RaspunsCuFlag==Urgent [tabela RaspunsDisponibil, coloana RaspunsCuFlag].

Query-ul trebuie facut paginat si ordonat dupa DataUltimeiModificari desc

Ex pentru urgente:

Intoarce 10 in acest moment (ar trebui 11). Pagina 10 intoarce un singur rezultat.

Adaugare model de response pentru statisticile simple:

Lista de:
public string Label {get; set;}
public string Value {get; set;}

• model PaginareRaspuns (Page; PageSize; Total)

Query-ul da timeout. Daca se mareste time-out ul, call-ul dureaza cca 2 min.

Connected issue with more background: code4romania/monitorizare-vot#103

In the dashboard we would need:

• overview of the team (also an individual observer)
  • where are
  • all the forms
  • all the notes and photos

• map where are observers
• map with metrics overlayed over administrative boundaries
• status of forms filled and notes count by each observer / team
• simple pie charts for each questions
• temporal reports: see what commissions have started counting at which hour, how long did it take, etc.
• total amount spend observing
• number of active observers / total observers

npm WARN tarball tarball data for [email protected] (sha1-PFtv1/beCRQmkCfwPAlGdY92c6Q=) seems to be corrupted. Trying one more time.

npm WARN The package typescript is included as both a dev and production dependency.

@angular/[email protected] requires typescript@'>=2.0.2 <2.3.0' but 2.9.2 was found instead.
Using this version can result in undefined behaviour and difficult to debug problems.

Please run the following command to install a compatible version of TypeScript.

    npm install typescript@'>=2.0.2 <2.3.0'

To disable this warning run "ng set warnings.typescriptMismatch=false".

The --missing-translation parameter will be ignored because it is only compatible with Angular version 4.2.0 or higher. If you want to use it, please upgrade your Angular version.

Running on node:10

Feats

• some basic ones
• Observers want to use two devices - it should be handled by the backend (two virtual observers)

API

• add a call to update information about a form
• add call info in swagger docs

Frontend

• display an edit form button in the list of available forms
• implement screen for editing form data

Best practices

• codebase language should be English
• we 💕 unit tests

• API task: update /api/v1/formulare endpoint to accept a PUT method on an existing form, to update the information of that particular form
• Frontend task: display an edit button on form list view, features to edit form code, form description, edit flag that marks if a form is completed

Filtru (din model) contine :

• public string IdIntrebare { get; set; }

Returneaza numarul raspunsurilor date de observatorii unui anumit ONG grupate pe optiuni pentru o anumita intrebare.

Filtru (din model) contine :

• public string IdFormular { get; set; }

Returneaza structura formularului pe baza id-ului acestuia.

Legat de filtrele pentru anumite statistici, cum s'au modificat recent, nu am o explicatie sau un design si flow, le voi exclude din lista de statistici.

De vazut cum integram aceste statisici la urmatoarea versiune

Run Export #32 on a predefined regularity

Have in the system the concept of coordinators who are taking care of group of observers/teams

• coordinators could pass on observers between themselves (group of observers)
• what's app invite link to the group between coordinator and an observer/team so another person can step in
• dashboard of a coordinator
  • all their observers / teams
  • where are they

Filtru (din model) contine :

• public int IdSectieDeVotare { get; set; }
• public int IdObservator { get; set; }

Returneaza notele atasate unei sesizari pe baza id-ului observatorului si id-ului sectiei de votare, ordonate crescator dupa id formular si cod sectiune.

• Citire claim "Organizator"
• In cazul in care utilizatorul este Organizator, nu mai trebuie filtrare query-urile dupa IdOng

• Redenumire endpoint "SesizariNumarareOptiuni" in "RaspunsuriNumarareOptiuni"
• Actualizare query sa returneze si optiunile care nu au nici un raspuns si pentru care Count = 0

trebuie pusa o setare in appsettings

Ca Admin ONG , cand accesez o sesizare din lista de sesizari sau urgente vreau sa vad deasupra tab-urilor informatiile despre sesizare (ora sosirii, ora plecarii, BESV, etc)