codastic / react-positioning-portal Goto Github PK

Hey Codastic team!

I came across this package and gave it a try, but it doesn't seem to have any affect on the DOM. It doesn't seem to be creating a portal, or using one I pass in if I use the rootNode prop.

I tried making my portalContent a function and logging relatedWidth each time it executes, but it apparently never executes. Any ideas? Thanks for sharing!

Thank you for this component. I have a problem/feature request:

Problem:

If the calculated position for the portal is in an area of the parent div that is not visible, the portal is not visible.

Duplication:

1. Run the scrollable test: https://codastic.github.io/react-positioning-portal/?path=/story/example-tooltip--scrollable-test
2. Move your window to the right so that the right edge, up to the button is not visible:

3. Hover over the button
4. Observe that the portal can not be seen

Desired Solution:

Consider what's visible in the positioning strategy and, in this case, put the portal on the left of the button instead, and in general find a way to make it visible.

Hi I like the component, getting this warning however:

Warning: findDOMNode is deprecated in StrictMode

I think they want you to use refs, I see in the code you have marked is a difficult issue, I think it might be possible using this method:

https://stackoverflow.com/questions/29568721/getting-dom-node-from-react-child-element

Hey there,

would it be okay to add relatedHeight (the parent height) as a property to the portalContent render function?

If yes, I here is the PR for this.

Best

Alex