Git Product home page Git Product logo

bots's People

Contributors

allisonkarlitskaya avatar atodorov avatar bcl avatar cockpituous avatar croissanne avatar henrywang avatar jelly avatar jikortus avatar jkonecny12 avatar jkozol avatar jrusz avatar jscotka avatar kkoukiou avatar larskarlitski avatar lgtm-migrator avatar lunarequest avatar m4rtink avatar martinpitt avatar marusak avatar mvollmer avatar nykseli avatar ptoscano avatar skobyda avatar subhoghoshx avatar tomasmatus avatar velezd avatar vladimirslavik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bots's Issues

bots: Move test maps out of tests-scan into the projects

Now that we have other repositories using bots/ and depending on Cockpit CI infra, namely lorax, I think it makes sense to try and read the context from a file inside the current repository, not hard-code it in bots/tests-scan.

Shouldn't be too hard to implement, let me know what you think ?

Traceback with tests-trigger without GITHUB_BASE

$ ./bots/tests-trigger --repo weldr/lorax 840 fedora-30/vmware
error: unknown option `default='
usage: git config [options]

Config file location
    --global              use global config file
    --system              use system config file
    --local               use repository config file
    -f, --file <file>     use given config file
    --blob <blob-id>      read config from given blob object

Action
    --get                 get value: name [value-regex]
    --get-all             get all values: key [value-regex]
    --get-regexp          get values for regexp: name-regex [value-regex]
    --replace-all         replace all matching variables: name value [value_regex]
    --add                 add a new variable: name value
    --unset               remove a variable: name [value-regex]
    --unset-all           remove all matches: name [value-regex]
    --rename-section      rename section: old-name new-name
    --remove-section      remove a section: name
    -l, --list            list all
    -e, --edit            open an editor
    --get-color <slot>    find the color configured: [default]
    --get-colorbool <slot>
                          find the color setting: [stdout-is-tty]

Type
    --bool                value is "true" or "false"
    --int                 value is decimal number
    --bool-or-int         value is --bool or --int
    --path                value is a path (file or directory name)

Other
    -z, --null            terminate values with NUL byte
    --includes            respect include directives on lookup

Traceback (most recent call last):
  File "./bots/tests-trigger", line 8, in <module>
    from task import github
  File "/home/atodorov/repos/git/weldr/lorax/bots/task/__init__.py", line 60, in <module>
    BASE = BOTS if api.repo == "cockpit-project/bots" else os.path.normpath(os.path.join(BOTS, ".."))
  File "/home/atodorov/repos/git/weldr/lorax/bots/task/github.py", line 152, in repo
    self._repo = os.environ.get("GITHUB_BASE", None) or get_repo() or get_origin_repo()
  File "/home/atodorov/repos/git/weldr/lorax/bots/task/github.py", line 105, in get_repo
    res = subprocess.check_output(['git', 'config', '--default=', 'cockpit.bots.github-repo'])
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 336, in check_output
    **kwargs).stdout
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 418, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['git', 'config', '--default=', 'cockpit.bots.github-repo']' returned non-zero exit status 129.

My git version is git-1.8.3.1-20.el7.x86_64 (RHEL 7 latest) which doesn't support the --default option for git config. However the same command in the same form was working for me before (I haven't tried it in the past few weeks I think, not before bots moved to this repo).

Workaround:

$ GITHUB_BASE=weldr/lorax ./bots/tests-trigger --repo weldr/lorax 840 fedora-30/vmware
fedora-30/vmware: triggering on pull request 840

cc @martinpitt

Update stale known issues

Check for any stale known issues and open a pull request to close them

  • naughty-prune

edit to test

udisksd crash in check-storage-mdraid

Refreshing the debian-testing image (PR cockpit-project/cockpit#7812) updates udisks from 2.6.5 to 2.7.3 (glib and polkit stay the same), which triggers a new crash:

# testNotRemovingDisks (check_storage_mdraid.TestStorage)
#
Warning: Permanently added '[127.0.0.2]:2301' (ECDSA) to the list of known hosts.
Traceback (most recent call last):
  File "/build/cockpit/bots/../test/verify/check-storage-mdraid", line 284, in testNotRemovingDisks
    b.wait_in_text(info_field("State"), "Running")
  File "/build/cockpit/test/common/testlib.py", line 257, in wait_in_text
    return self.wait_js_func('ph_in_text', selector, text)
  File "/build/cockpit/test/common/testlib.py", line 224, in wait_js_func
    return self.phantom.wait("%s(%s)" % (func, ','.join(map(jsquote, args))))
  File "/build/cockpit/test/common/testlib.py", line 825, in <lambda>
    return lambda *args: self._invoke(name, *args)
  File "/build/cockpit/test/common/testlib.py", line 851, in _invoke
    raise Error(res['error'])
Error: timeout

This is due to udisksd crashing. I filed an upstream report at storaged-project/udisks#422 and use this one as naughty override.

RHEL, CentOS, Fedora, Debian, Ubuntu: PCP libraries crash in __pmFindProfile()

PR cockpit-project/cockpit#6102 apparently aggravates (due to changed timing) this flaky test failure:

not ok 3 testFrameNavigation (__main__.TestMultiMachine) duration: 27s
Traceback (most recent call last):
  File "test/verify/check-multi-machine", line 202, in tearDown
    MachineCase.tearDown(self)
  File "/home/martin/upstream/cockpit/test/common/testlib.py", line 533, in tearDown
    self.check_journal_messages()
  File "/home/martin/upstream/cockpit/test/common/testlib.py", line 689, in check_journal_messages
    raise Error(first)
Error: /usr/libexec/cockpit-pcp: bridge was killed: 11

This was reported a while ago as https://bugzilla.redhat.com/show_bug.cgi?id=1235962 and I confirmed it with pcp 3.11.8-2.fc25.x86_64. That downstream bug has the strack trace and some initial analysis. Filing this one to use it as "known issue" naughty quirk.

rhsmd gets lots of write SELinux violations on Atomic

See downstream issue: https://bugzilla.redhat.com/show_bug.cgi?id=1556763

Spotted in cockpit-project/cockpit#8822, example failure:

Traceback (most recent call last):
  File "/build/cockpit/test/common/testlib.py", line 664, in tearDown
    self.check_journal_messages()
  File "/build/cockpit/test/common/testlib.py", line 802, in check_journal_messages
    raise Error(first)
Error: type=1400 audit(1521047735.710:5): avc:  denied  { write } for  pid=1506 comm="rhsmd" name="encodings" dev="dm-0" ino=6446470 scontext=system_u:system_r:rhsmcertd_t:s0-s0:c0.c1023 tcontext=system_u:object_r:lib_t:s0 tclass=dir

not ok 19 testExternalPage (check_multi_machine.TestMultiMachine) # duration: 142s

RHEL 8.2 regression: setting time fails: avc: denied { sys_time } for comm="timedatex"

This breaks three tests. Symptom:

# timedatectl set-time '2020-01-01 15:30:00'
audit: type=1400 audit(1574167631.911:5): avc:  denied  { sys_time } for  pid=1501 comm="timedatex" capability=25  scontext=system_u:system_r:timedatex_t:s0 tcontext=system_u:system_r:timedatex_t:s0 tclass=capability permissive=0

Failed to set time: Failed to set system clock: Operation not permitted

Downstream report: https://bugzilla.redhat.com/show_bug.cgi?id=177401

Follow-up report: https://bugzilla.redhat.com/show_bug.cgi?id=1779098

image-customize --install is not idempotent

It uses dnf install by default, which doesn't reinstall the package if it's already installed.

This is not easily solved by using --install-command, because one needs to remove the package first and the install it (dnf reinstall fails in the other case: when the package is not yet installed or at an older version).

Selinux prevents setting timezone via timedatectl, prevents write to /etc/localtime

OS: fedora-31

Selinux prevents setting timezone via timedatectl.

timedatectl set-timezone Europe/Helsinki

> Failed to set time zone: Failed to update /etc/localtime

audit: type=1400 audit(1567689788.617:317): avc:  denied  { write } for  pid=7096 comm="timedatex" name="etc" dev="dm-0" ino=130051 scontext=system_u:system_r:timedatex_t:s0 tcontext=system_u:object_r:etc_t:s0 tclass=dir permissive=0

https://bugzilla.redhat.com/show_bug.cgi?id=1749375

Debian: parted clobbers in-memory state of extended partitions

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842269

See also https://bugzilla.redhat.com/show_bug.cgi?id=1135493 for the original.

This has been fixed with a path in Fedora only, it wasn't fixed upstream. Thus, debian-unstable suffers from it.

Basically, parted tells the kernel the wrong size for extended partitions.

Apparently, the bug was masked on debian-unstable by systemd-udevd independently re-reading the partition table. However, recent versions of Storaged block systemd-udevd from re-reading since that causes other bugs. Thus, this bug is now visible.

Podman cannot load stats from rootless containers

Reported: containers/podman#4268
Logs in console: > warning: Failed to update container stats: {"error":"io.podman.ErrorOccurred","parameters":{"reason":"Link not found"}}
Fails with:

Traceback (most recent call last):
  File "test/check-application", line 441, in testLifecycleOperationsUser
    self._testLifecycleOperations(False)
  File "test/check-application", line 477, in _testLifecycleOperations
    self.assertIn('%', cpu)
AssertionError: '%' not found in ''

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.