Git Product home page Git Product logo

Comments (5)

sei-ccohen avatar sei-ccohen commented on August 13, 2024

Thanks for this bug report. It looks like the problem is related to the JSON exporter, not the actual Prolog results, which is good news, because detection problems are usually harder to fix than reporting problems. It will probably take us a while to fix this, but it's on the list now.

from pharos.

lcytxw avatar lcytxw commented on August 13, 2024

Thank you. This work is really meaningful.

from pharos.

sei-ccohen avatar sei-ccohen commented on August 13, 2024

Just adding additional notes about this bug to make it clearer what the problem is. The JSON results for ooex_vs2008/Debug/oo.exe report:

"Vcalls": [{ "call": "4116a2", "targets": [{ "ea": "411970" }]}]

But the Prolog results for the same file are:

finalResolvedVirtualCall(0x4116a2, 0x417824, 0x411970).
finalResolvedVirtualCall(0x4116bb, 0x417814, 0x4119f0).
finalResolvedVirtualCall(0x4116d5, 0x417814, 0x4118f0).
finalResolvedVirtualCall(0x4116ea, 0x417824, 0x411970).

So it appears that perhaps our JSON reporter only ever reports the first virtual call?

from pharos.

jeffgennari avatar jeffgennari commented on August 13, 2024

The code to pull out virtual function call targets examines call descriptors. which apparently do not account for multiple targets:

const CallDescriptor* vcall = pair.first;

from pharos.

Trass3r avatar Trass3r commented on August 13, 2024

Indeed I got 52 finalResolvedVirtualCall's in another test (from different callsites) but only a single VCalls entry in the entire json file.

from pharos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.