Comments (12)
turol
commented on August 13, 2024
1
Single-parameter constructor should probably be marked explicit.
from pharos.
sei-eschwartz
commented on August 13, 2024
What version of g++ are you using? This is the right place to ask!
Sent from my T-Mobile 5G Device
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: SwoolBean ***@***.***>
Sent: Friday, September 15, 2023 3:24:11 AM
To: cmu-sei/pharos ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [cmu-sei/pharos] Build error running make on CentOS 7 (error: constructor required before non-static data member) (Issue #257)
Hi!
Hoping this is the right place to ask about this. I followed the installation guide for manually building from source to get Pharos working on my CentOS 7 virtual machine. As far as I can tell, I've managed to get all the dependencies built and installed, but when I run make -j4 in Pharos' build directory, I get this error about halfway through the build:
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits:878:48: error: constructor required before non-static data member for ‘pharos::PathFinder::SolverDeleter::owned’ has been parsed
template<typename _Tp, typename = decltype(_Tp())>
with make finishing with this output:
make[2]: *** [libpharos/CMakeFiles/pharos.dir/options.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [libpharos/CMakeFiles/pharos.dir/path.cpp.o] Error 1
make[1]: *** [libpharos/CMakeFiles/pharos.dir/all] Error 2
make: *** [all] Error 2
Because I previously had an issue with CMake targeting an older version of C++, I also tried running it with extra flags to lock the version down, but I got the same error:
sudo cmake -DCMAKE_INSTALL_PREFIX=/usr/local .. -DCMAKE_CXX_STANDARD=14 -DCMAKE_CXX_STANDARD_REQUIRED=ON
I know that CentOS 7 isn't in your list of supported distributions for manually building, but RHEL 7 is, and in my experience that's a good indicator that CentOS 7 should be fine as well.
Please let me know if you need any more info or if I should be posting this somewhere else. Thanks!
—
Reply to this email directly, view it on GitHub<#257>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL6ZAVDJPC2K7IWLJOCREUDX2P7BXANCNFSM6AAAAAA4ZMCK3E>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
from pharos.
swoolbean
commented on August 13, 2024
I want to say 7.2.4, but my host machine actually bricked itself this morning, so I won't be able to check for a few weeks until it's repaired 😅
If I have some time this coming week, I'll try getting it set up on a different PC.
from pharos.
sei-ccohen
commented on August 13, 2024
I know that we've had to upgrade our compiler in the RedHat environment a couple of times. We're currently using devtoolset-11 in our build environment. I'm not certain what our minimum version requirement for the compiler is, but I know that we need C++14 support. I encourage you to upgrade the compiler for your next build.
from pharos.
sei-mwd
commented on August 13, 2024
C++14 is supposedly available from gcc 6.1 and up, but we haven't tested with versions of gcc that old in some time. It is possible that we accidentally have some code that is not C++14 compliant, but that compiles on later versions of gcc anyway. I could look at what is going on, but I would need more context from your original error message to trace down what is happening.
from pharos.
sei-mwd
commented on August 13, 2024
Did not mean to close this issue.
from pharos.
sei-eschwartz
commented on August 13, 2024
I was able to reproduce this with gcc 7.3.1 on centos 7 using the commands in this notebook: https://colab.research.google.com/drive/1RsbkTSUjuIlrdR4T73vo4mC-K0Adifq0?usp=sharing
But the notebook is slow because it uses udocker, so it's still catching up. This is from my machine:
[3/29] Building CXX object libpharos/CMakeFiles/pharos.dir/options.cpp.o
FAILED: libpharos/CMakeFiles/pharos.dir/options.cpp.o
/opt/rh/devtoolset-7/root/usr/bin/c++ -Dpharos_EXPORTS -I/root/pharos/scripts/build/libpharos -isystem /usr/local/include/rose -isystem /usr/local/lib/swipl/include -pedantic -pedantic-errors -Wall -Wextra -Wshadow -Wstrict-aliasing -Wno-misleading-indentation -ftemplate-depth=1024 -ftrack-macro-expansion=0 -O3 -DNDEBUG -std=c++14 -fPIC -pthread -Winvalid-pch -include /root/pharos/scripts/build/libpharos/CMakeFiles/pharos.dir/cmake_pch.hxx -MD -MT libpharos/CMakeFiles/pharos.dir/options.cpp.o -MF libpharos/CMakeFiles/pharos.dir/options.cpp.o.d -o libpharos/CMakeFiles/pharos.dir/options.cpp.o -c /root/pharos/libpharos/options.cpp
In file included from /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/move.h:54:0,
from /opt/rh/devtoolset-7/root/usr/include/c++/7/bits/nested_exception.h:40,
from /opt/rh/devtoolset-7/root/usr/include/c++/7/exception:143,
from /opt/rh/devtoolset-7/root/usr/include/c++/7/ios:39,
from /opt/rh/devtoolset-7/root/usr/include/c++/7/ostream:38,
from /usr/local/include/boost/system/error_code.hpp:19,
from /usr/local/include/boost/filesystem/path_traits.hpp:23,
from /usr/local/include/boost/filesystem/path.hpp:25,
from /usr/local/include/boost/filesystem.hpp:16,
from /usr/local/include/rose/sage3basic.h:42,
from /usr/local/include/rose/sage3basic.hhh:4,
from /usr/local/include/rose/rose.h:10,
from /root/pharos/scripts/build/libpharos/CMakeFiles/pharos.dir/cmake_pch.hxx:5,
from <command-line>:0:
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits: In substitution of 'template<class _Tp, class> static std::true_type std::__do_is_default_constructible_impl::__test(int) [with _Tp = pharos::PathFinder::SolverDeleter; <template-parameter-1-2> = <missing>]':
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits:889:35: required from 'struct std::__is_default_constructible_impl<pharos::PathFinder::SolverDeleter>'
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits:143:12: required from 'struct std::__and_<std::__not_<std::is_void<pharos::PathFinder::SolverDeleter> >, std::__is_default_constructible_impl<pharos::PathFinder::SolverDeleter> >'
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits:893:12: required from 'struct std::__is_default_constructible_atom<pharos::PathFinder::SolverDeleter>'
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits:914:12: required from 'struct std::__is_default_constructible_safe<pharos::PathFinder::SolverDeleter, false>'
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits:920:12: required from 'struct std::is_default_constructible<pharos::PathFinder::SolverDeleter>'
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits:143:12: required from 'struct std::__and_<std::__not_<std::is_pointer<pharos::PathFinder::SolverDeleter> >, std::is_default_constructible<pharos::PathFinder::SolverDeleter> >'
/opt/rh/devtoolset-7/root/usr/include/c++/7/bits/unique_ptr.h:135:47: required from 'class std::__uniq_ptr_impl<pharos::PharosZ3Solver, pharos::PathFinder::SolverDeleter>'
/opt/rh/devtoolset-7/root/usr/include/c++/7/bits/unique_ptr.h:163:33: required from 'class std::unique_ptr<pharos::PharosZ3Solver, pharos::PathFinder::SolverDeleter>'
/root/pharos/libpharos/path.hpp:303:0: required from here
/opt/rh/devtoolset-7/root/usr/include/c++/7/type_traits:878:48: error: constructor required before non-static data member for 'pharos::PathFinder::SolverDeleter::owned' has been parsed
template<typename _Tp, typename = decltype(_Tp())>
from pharos.
sei-eschwartz
commented on August 13, 2024
https://stackoverflow.com/a/17436088
from pharos.
sei-eschwartz
commented on August 13, 2024
This fixed it for me, but @sei-mwd might have a more elegant solution:
[root@ed-Precision-7540 libpharos]# git diff
diff --git a/libpharos/path.hpp b/libpharos/path.hpp
index a89b20a..2b31766 100644
--- a/libpharos/path.hpp
+++ b/libpharos/path.hpp
@@ -297,6 +297,8 @@ class PathFinder : public Z3PathAnalyzer {
struct SolverDeleter {
bool owned = true;
void operator()(PharosZ3Solver *s) const { if (owned) delete s; }
+ SolverDeleter() {}
+ explicit SolverDeleter(bool owned_) : owned(owned_) {}
};
// We will need Z3 for this analysis
The default constructor is needed for unique_ptr, and the second one is needed because we use SolverDeleter{false} somewhere.
from pharos.
sei-mwd
commented on August 13, 2024
Okay. This looks like a bug in the C++ standard library in that version of gcc. The fix that @sei-eschwartz posted is harmless, so I'll commit a variant of it shortly.
from pharos.
Related Issues (20)
- Merge reasonMethod changes HOT 1
- Calling conventions and being smarter about statically linked binaries
- SQLite concurrency problem in OOAnalyzer HOT 28
- DKII consistency failures HOT 5
- APIAnalyzer use-after-free HOT 1
- Stop the lies
- stop being rude and stupid
- no need to create lies HOT 1
- ooprolog crash HOT 16
- Consistency checks failed in ooprolog. HOT 22
- Partition stuck at 94%, seems to not be using available memory HOT 14
- Partitioner stucks at 17 % and often gets killed HOT 4
- crash in partitioning: basic block does not contain instruction HOT 8
- Is there a method to exclude classes by name? HOT 29
- Add Support For Non-Standard Windows Based Executables. HOT 6
- Initial sanity check failed in ooprolog HOT 6
- Contribute to OOAnalyzer HOT 1
- Where can I find a plugin for Ghidra? HOT 1
- WSL: cannot see file mapped HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pharos.