Git Product home page Git Product logo

Comments (4)

Josh68 avatar Josh68 commented on June 3, 2024 1

Fair enough. The only reason I created this was that adding ds-u-display--block to the badge screws up its layout. But you're right, the general assumption (not stated outright) is that a badge is meant to lay out inline.

from design-system.

pwolfert avatar pwolfert commented on June 3, 2024

What about wrapping it in a block element like div or p in those cases?

from design-system.

Josh68 avatar Josh68 commented on June 3, 2024

What about wrapping it in a block element like div or p in those cases?

That was our workaround (actually, now, setting ds-u-display--block on the Button). And there are combinations of classes that will work, as explained. Just thought this might be a good addition to avoid adding extraneous markup. If it's not worth the work, you may close.

from design-system.

pwolfert avatar pwolfert commented on June 3, 2024

I don't think it's worth its own special class or logic in the component, and it's partly because the guidelines for when and how to use badges are non-existent. The pattern of using badges needs to be developed more before we start adding more code to them

from design-system.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.