Comments (6)
Fixed in #2566
from design-system.
+1. Just confirming that we're seeing this issue in MCT after upgrading to MGov DS v8.1.1
from design-system.
@austindh and @Josh68, what are your apps currently using the inputRef
for? Focus management?
from design-system.
Yes, for focus management. We use it to focus on the dropdown if the user attempts to continue without making a selection.
from design-system.
I'm actually seeing similar warnings on Autocomplete
, with focusTrigger
and labelId
. In this case, these aren't even props we're passing in. The warnings are being generated just because we're using the DS component.
For inputRef
on the Dropdown
(at least in one place) we're using it to programmatically keep multiple parts of the UI in sync (can't elaborate more than that without digging in further).
We did not see these errors before the upgrade to DS V8, AFAIK.
from design-system.
Good information. Thanks, all! We do have an autoFocus
prop for putting focus on the component, but I realize there might be situations where inputRef
is easier to use. CC @forrestbaer and @zarahzachz
The Autocomplete
warnings I think we've addressed in the current beta version, but overall we can do more to clean up props and make them consistent.
from design-system.
Related Issues (20)
- Sass compilation errors HOT 7
- [Accessibility] Add documentation for adding "Error" to page title HOT 3
- Add a print icon HOT 1
- Tooltips open on touchmove
- Migration Script Error HOT 5
- Request for documentation for a pattern and guidance for links/buttons that are document downloads, i.e. PDF HOT 1
- Inline form errors should indicate they're errors to screen readers HOT 4
- [Accessibility] h4 in footer component causes heading order issues HOT 1
- Calendar Picker Component allows for unlimited entry of numbers
- [Accessibility] healthcare.gov logo's svg elements are being read out by VoiceOver HOT 1
- Allow Alerts to take custom icons
- [Accessibility] Footer social icons do not provide an accessible name HOT 3
- Versions of @types/react greater than 18.2.21 cause TypeScript errors
- Spinner does not cover Dialog HOT 6
- Wrong code on NPM for 7.0.7 release HOT 1
- Badge: Add variation that allows the badge to display block HOT 4
- Add more font weights for custom fonts HOT 1
- ChoiceList "hint" states Hints are their own component HOT 3
- Choice List hint wrapping text prematurely
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from design-system.