Git Product home page Git Product logo

Comments (6)

pwolfert avatar pwolfert commented on June 11, 2024 1

Fixed in #2566

from design-system.

Josh68 avatar Josh68 commented on June 11, 2024

+1. Just confirming that we're seeing this issue in MCT after upgrading to MGov DS v8.1.1

from design-system.

pwolfert avatar pwolfert commented on June 11, 2024

@austindh and @Josh68, what are your apps currently using the inputRef for? Focus management?

from design-system.

austindh avatar austindh commented on June 11, 2024

Yes, for focus management. We use it to focus on the dropdown if the user attempts to continue without making a selection.

from design-system.

Josh68 avatar Josh68 commented on June 11, 2024

I'm actually seeing similar warnings on Autocomplete, with focusTrigger and labelId. In this case, these aren't even props we're passing in. The warnings are being generated just because we're using the DS component.

For inputRef on the Dropdown (at least in one place) we're using it to programmatically keep multiple parts of the UI in sync (can't elaborate more than that without digging in further).

We did not see these errors before the upgrade to DS V8, AFAIK.

from design-system.

pwolfert avatar pwolfert commented on June 11, 2024

Good information. Thanks, all! We do have an autoFocus prop for putting focus on the component, but I realize there might be situations where inputRef is easier to use. CC @forrestbaer and @zarahzachz

The Autocomplete warnings I think we've addressed in the current beta version, but overall we can do more to clean up props and make them consistent.

from design-system.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.