Comments (4)
MihaiSurdeanu
commented on August 30, 2024
Thanks to your PR, this test now passes. However, others failures showed up in the corenlp subproject. They are all caused by this error:
11:31:34.023 [pool-1-thread-1-ScalaTest-running-TestCoreNLPSentimentAnalyzer] INFO edu.stanford.nlp.parser.lexparser.LexicalizedParser - Loading parser from serialized file edu/stanford/nlp/models/lexparser/englishPCFG.ser.gz ... done [0.1 sec].
[info] - should correctly assign sentiment scores for negative cases *** FAILED ***
[info] java.lang.NullPointerException:
[info] at java.util.zip.InflaterInputStream.<init>(InflaterInputStream.java:83)
[info] at java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:77)
[info] at java.util.zip.GZIPInputStream.<init>(GZIPInputStream.java:91)
[info] at org.clulab.processors.shallownlp.ShallowNLPProcessor.mkChunker(ShallowNLPProcessor.scala:84)
[info] at org.clulab.processors.shallownlp.ShallowNLPProcessor.chunker$lzycompute(ShallowNLPProcessor.scala:53)
[info] at org.clulab.processors.shallownlp.ShallowNLPProcessor.chunker(ShallowNLPProcessor.scala:53)
[info] at org.clulab.processors.shallownlp.ShallowNLPProcessor.$anonfun$chunking$1(ShallowNLPProcessor.scala:289)
[info] at org.clulab.processors.shallownlp.ShallowNLPProcessor.$anonfun$chunking$1$adapted(ShallowNLPProcessor.scala:286)
[info] at scala.collection.IndexedSeqOptimized.foreach(IndexedSeqOptimized.scala:36)
[info] at scala.collection.IndexedSeqOptimized.foreach$(IndexedSeqOptimized.scala:33)
[info] ...
This error happens because this model:
https://github.com/clulab/processors/blob/balaur-minus-dynet/corenlp/src/main/scala/org/clulab/processors/shallownlp/ShallowNLPProcessor.scala#L82
is no longer available because I removed the dependency to processors-models, which includes it.
Can you please create a new jar file, let's call it corenlp-additional-models, which contains just this model?
Thank you!
Mihai
from processors.
kwalcock
commented on August 30, 2024
The file is 50MB and would fit on maven and github. Although it is nice to have all the models in the same place (artifactory), it also requires the custom resolver in order to use. Which would you rather have: maven/github or artifactory? It could be github and artifactory. Usually I don't make a github repo just to publish a resource on artifactory.
from processors.
kwalcock
commented on August 30, 2024
Perhaps even better, the file could be added to the processors-corenlp subproject as a resource and there wouldn't be an external dependency.
from processors.
MihaiSurdeanu
commented on August 30, 2024
Local resource would be best!
…On Wed, Aug 30, 2023, 1:29 PM Keith Alcock ***@***.***> wrote:
Perhaps even better, the file could be added to the processors-corenlp
subproject as a resource and there wouldn't be an external dependency.
—
Reply to this email directly, view it on GitHub
<#742 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI75TUTE3OBWYE4RZI7V3LXX6PC5ANCNFSM6AAAAAA4CGWF6Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
from processors.
Related Issues (20)
- Normalize "grand" HOT 7
- Unreliable tests HOT 2
- The webapp messes up the project in IntelliJ HOT 3
- Preferred size of graphs is not set upon Document deserialization HOT 3
- Hashing is inconsistent HOT 2
- equivalenceHash makes use of hashCode
- pounds as measurements HOT 1
- Paths are written for Mentions that are non-arguments but not read back in
- Update dependency on scala-collection-compat HOT 1
- The Core NLP processors don't understand Easter or Mother's Day and throws an exception HOT 8
- TestLemmatizer failing with BalaurProcessor HOT 23
- "Due to", the exceptional case handled in PostProcessor HOT 2
- Java interface for processors HOT 5
- Balaur tests need to pass before it can be merged into master. HOT 7
- Date rule doesn't match well with action HOT 3
- WEEK.tsv better handled in code
- Adverse effect of processors v9 on eidos HOT 5
- Quote is shoved to next sentence
- TokenPattern.assignIds never visits the start of MatchLookAhead or MatchLookBehind
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from processors.