cloudposse / terraform-aws-s3-website Goto Github PK

#31 fixes this

Describe the Bug

Fails to apply module, complaining about logs config

╷
│ Error: Unsupported attribute
│ 
│   on .terraform/modules/this.website_with_cname.logs/main.tf line 26, in resource "aws_s3_bucket" "default":
│   26:       for_each = var.enable_glacier_transition ? [1] : []
│ 
│ This object does not have an attribute named "enable_glacier_transition".
╵
╷
│ Error: Unsupported attribute
│ 
│   on .terraform/modules/this.website_with_cname.logs/main.tf line 40, in resource "aws_s3_bucket" "default":
│   40:       for_each = var.enable_glacier_transition ? [1] : []
│ 
│ This object does not have an attribute named "enable_glacier_transition".
╵

Expected Behavior

vanilla module useage should succeed.

Steps to Reproduce

Steps to reproduce the behavior:

module "website_with_cname" {
  source = "cloudposse/s3-website/aws"
  version = "v0.17.1"
  context        = module.this
  hostname       = "shipment-2.${var.domain}"
  parent_zone_id = var.frontend_zone_id
  logs_enabled   = true
  logs_expiration_days = 10
}

with:

Terraform v1.0.3
on darwin_amd64
+ provider registry.terraform.io/hashicorp/aws v4.1.0
+ provider registry.terraform.io/hashicorp/local v2.1.0
+ provider registry.terraform.io/hashicorp/random v3.1.0
+ provider registry.terraform.io/hashicorp/tls v3.1.0

run:

terraform init
terraform apply

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

• OS: OSX

Found a bug? Maybe our Slack Community can help.

Describe the Bug

The module does not adhere module.this.enabled (Resources do not have a count attribute: https://github.com/cloudposse/terraform-aws-s3-website/blob/master/main.tf#L38).

Expected Behavior

When module.this.enabled=false, no resources should be created.

Steps to Reproduce

Steps to reproduce the behavior:

1. Instantiate module with module.this.enabled=false
2. Run terraform plan

Logs

...
 # module.s3_website.aws_s3_bucket.default will be created
  + resource "aws_s3_bucket" "default" {
...

Environment (please complete the following information):

Terraform 0.13.7

Additional Context

N/A

here is the module that we are using

module "test" {
source = "git::https://github.com/cloudposse/terraform-aws-s3-website.git?ref=tags/0.17.1"
stage = local.env
error_document = "index.html"
hostname = local.my_tasks_web_client_hostname
index_document = "index.html"
parent_zone_name = local.domain_suffix
versioning_enabled = true
}

Error: Unsupported attribute
on .terraform/modules/my_tasks_web_client_with_cname.logs/main.tf line 26, in resource "aws_s3_bucket" "default":
26: for_each = var.enable_glacier_transition ? [1] : []
This object does not have an attribute named "enable_glacier_transition".
Error: Unsupported attribute
on .terraform/modules/my_tasks_web_client_with_cname.logs/main.tf line 40, in resource "aws_s3_bucket" "default":
40: for_each = var.enable_glacier_transition ? [1] : []
This object does not have an attribute named "enable_glacier_transition".

Pardon my improper form, but changes to the default settings for S3 buckets are causing this module to fail:

https://github.com/cloudposse/terraform-aws-s3-website/blob/master/main.tf#L47

https://docs.aws.amazon.com/AmazonS3/latest/userguide/create-bucket-faq.html

'Starting in April 2023, Amazon S3 will change the default settings for S3 Block Public Access and S3 Object Ownership (ACLs disabled) for all new S3 buckets.'

It results in this error:

Error: Error creating S3 bucket: InvalidBucketAclWithObjectOwnership: Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting

what

• Add example invocation

why

• We need this so we can soon enable automated continuous integration testing of module

maint.tf

module "website" {
  source         = "git::https://github.com/cloudposse/terraform-aws-s3-website.git?ref=tags/0.8.0"
  namespace      = "testing"
  stage          = "test"
  name           = "example"
  hostname       = "my.domain.url"
  parent_zone_id = "MY_HOSTED_ZONE_ID"
}

CLI output:

>$ terraform init
Initializing modules...
- module.website
  Getting source "git::https://github.com/cloudposse/terraform-aws-s3-website.git?ref=tags/0.8.0"
Error downloading modules: Error loading modules: module website: Error parsing .terraform/modules/4cf3ef66ea09db16cc440026e6b45b9e/main.tf: At 4:7: error while trying to parse object within list: At 5:36: Unknown token: 5:36 IDENT var.redirect_all_requests_to

I would like to note that 0.7.0 works as expected.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• chore(deps): update terraform cloudposse/s3-log-storage/aws to v1.4.3

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature

• cloudposse/s3-log-storage/aws depends on cloudposse/s3-bucket/aws, which requires v4 of the AWS Provider
• context.tf is still using null-label 0.24.1. instead of 0.25.0

Expected Behavior

This module should use the latest version of the aforementioned dependencies

Use Case

• Latest dependencies should be used
• tenant label cannot be used because null-label 0.25.0 is not used

Describe Ideal Solution

Support latest AWS Provider and manually update context.tf

Alternatives Considered

N/A

Additional Context

N/A

Describe the Bug

I am getting the following version error when using cloudposse/s3-website/aws version 0.17.3 with:

provider "registry.terraform.io/hashicorp/aws" {
  version     = "4.48.0"
....
}

Error: Failed to query available provider packages
Could not retrieve the list of available versions for provider hashicorp/aws: no available releases match the given constraints >= 2.0.0, >= 2.70.0, >= 3.0.0, >= 3.26.0, >= 3.29.0, >= 3.73.0, ~> 4.0, < 4.0.0, >= 4.8.0,
 >= 4.9.0, >= 4.21.0, >= 4.45.0

I saw here the restriction was added and here it should work.

Steps to Reproduce

Steps to reproduce the behavior:

1. terraform init -upgrade with AWS provider in the latest version

Found a bug? Maybe our Slack Community can help.

Describe the Bug

The module logs doesnt take var.tags as input. Therefore, user-defined tags cannot be injected into s3 bucket for logging created by this module has only default tags.

Expected Behavior

The module logs doesnt accept var.tags as input.

Steps to Reproduce

Steps to reproduce the behavior:

1. Define tags
2. Run the module
3. Check the s3 bucket created to save the logs.
4. Tags defined in step 1 are not available

Anything that will help us triage the bug will help. Here are some ideas:

• https://github.com/cloudposse/terraform-aws-s3-website/blob/0.9.0/main.tf
• module tag is 0.9.0

Hi can you update this code to support terraform 0.12 ?

Thank you for open sourcing this module.

Have noticed that the logs bucket allows some objects to be set to public. I guess this could be useful in some situations but is not for our typical use case.
I've done a second resource in my main.tf implementing this:
https://github.com/cloudposse/terraform-aws-tfstate-backend/blob/master/main.tf#L119

If there's value I can submit a PR...

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Describe the Feature

Upgrade module to use AWS provider 4.x

Expected Behavior

Module is functional with current version of AWS provider.

Use Case

Typical usage.

Describe Ideal Solution

.

Alternatives Considered

.

Additional Context

.

Currently, the redirect_all_requests_to parameter for the aws_s3_bucket resource cannot be set. I propose we add this parameter, thereby enabling this module to be used in creating s3 website buckets with the sole purpose of redirecting requests.

https://www.terraform.io/docs/providers/aws/r/s3_bucket.html#redirect_all_requests_to

module Parameters

module "dev_front_end" {
  source         = "git::https://github.com/cloudposse/terraform-aws-s3-website.git?ref=master"
  namespace      = "namespace"
  stage          = "dev"
  name           = "front-app"
  hostname       = "front-app.local.XXXXX"

  parent_zone_id = "${var.parent_zone_id}"
  parent_zone_name = "local.XXXXX"
  region = "${var.region}"

  force_destroy = true 
  index_document = "index.html"
  error_document = "error.html"
  versioning_enabled = false

  cors_allowed_headers = [ "*" ]
  cors_allowed_methods = ["GET","PUT","POST","DELETE","HEAD"]
  cors_max_age_seconds = "3600"

  tags       = "${map("Key", "Value")}"

  deployment_actions = [ 
    "s3:PutObject",
    "s3:PutObjectAcl",
    "s3:GetObject",
    "s3:DeleteObject",
    "s3:ListBucket",
    "s3:ListBucketMultipartUploads",
    "s3:GetBucketLocation",
    "s3:AbortMultipartUpload" 
    ]
    
}

Error code

- destroy

Terraform will perform the following actions:

- module.website_with_cname.module.logs.aws_s3_bucket.default

- module.website_with_cname.module.logs.module.default_label.null_resource.default


Plan: 0 to add, 0 to change, 2 to destroy.

Do you want to perform these actions?
Terraform will perform the actions described above.
Only 'yes' will be accepted to approve.

Enter a value: yes

module.website_with_cname.module.logs.aws_s3_bucket.default: Destroying... (ID: namespace-dev-front-app-logs)

Error: Error applying plan:

1 error(s) occurred:

* module.website_with_cname.module.logs.aws_s3_bucket.default (destroy): 1 error(s) occurred:

* aws_s3_bucket.default: Error deleting S3 Bucket: BucketNotEmpty: The bucket you tried to delete is not empty. You must delete all versions in the bucket.
      status code: 409, request id: 8B4F5341B7E9CE89, host id: CgLQEla1tgfnFBNhBzwLQ3TRxEjShK6TShawoBrrmgiZXJgUeXdr7NI5IUWuTIezXvBS74FI4OY= "namespace-dev-front-app-logs"

Please do { force_destroy = true } for Logs bucket or disable Logs-bucket creation>