Git Product home page Git Product logo

worker-sites-init's People

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

worker-sites-init's Issues

Headers added by PR #12 break iframes

It appears that PR #12 adds an X-Frame-Options header set to DENY. We are currently using Cloudflare Sites to publish an internal React Storybook, and Storybook renders stories inside iframes, so this change has broken those deployments.

Would it be possible to make this header configurable in the wrangler.toml? We previously just set sites = "path/to/public/dir" to publish the site, but it doesn't look like there's a way to override this new header in the Wrangler config.

Updating @cloudflare/kv-asset-handler to 0.0.8 causes wrangler command to fail

Hey Cloudflare workers team

I've been trying to get routing to work properly on my react app and came across serveSinglePageApp in the later versions of @cloudflare/kv-asset-handler, however after manually bumping them to the latest version and installing, I get the following error after wrangler publish

๐Ÿ‘€  ./workers-site/index.js
Module not found: Error: Can't resolve '@cloudflare/kv-asset-handler' in '/Users/user/Documents/Apps/React/Projects/appName/workers-site'
resolve '@cloudflare/kv-asset-handler' in '/Users/user/Documents/Apps/React/Projects/appName/workers-site'
  Parsed request is a module
  using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/package.json (relative path: .)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /Users/user/Documents/Apps/React/Projects/node_modules doesn't exist or is not a directory
      /Users/user/Documents/Apps/React/node_modules doesn't exist or is not a directory
      /Users/user/Documents/Apps/node_modules doesn't exist or is not a directory
      /Users/user/Documents/node_modules doesn't exist or is not a directory
      /Users/user/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
      looking for modules in /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules
        using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
      looking for modules in /Users/user/Documents/Apps/React/Projects/appName/node_modules
        using description file: /Users/user/Documents/Apps/React/Projects/appName/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/package.json (relative path: .)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler is not a file
            .wasm
              Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/user/Documents/Apps/React/Projects/appName/package.json (relative path: ./node_modules/@cloudflare/kv-asset-handler)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.wasm doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler doesn't exist
            .wasm
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.wasm doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.json doesn't exist
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
            as directory
              existing directory
                use ./dist/index.js from main in package.json
                  using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/package.json (relative path: .)
                    Field 'browser' doesn't contain a valid alias configuration
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.json doesn't exist
            as directory
              /Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler doesn't exist
                    using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/package.json (relative path: ./dist/index.js)
                      no extension
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js doesn't exist
                      .wasm
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.wasm doesn't exist
                      .mjs
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.mjs doesn't exist
                      .js
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.js doesn't exist
                      .json
                        Field 'browser' doesn't contain a valid alias configuration
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.json doesn't exist
                      as directory
                        /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js doesn't exist
                using path: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index
                  using description file: /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/package.json (relative path: ./index)
                    no extension
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index doesn't exist
                    .wasm
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.wasm doesn't exist
                    .mjs
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.mjs doesn't exist
                    .js
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.js doesn't exist
                    .json
                      Field 'browser' doesn't contain a valid alias configuration
                      /Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.json doesn't exist
[/Users/user/Documents/Apps/React/Projects/node_modules]
[/Users/user/Documents/Apps/React/node_modules]
[/Users/user/Documents/Apps/node_modules]
[/Users/user/Documents/node_modules]
[/Users/user/node_modules]
[/Users/node_modules]
[/node_modules]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.wasm]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.mjs]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.wasm]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.js]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.mjs]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler.json]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.js]
[/Users/user/Documents/Apps/React/Projects/appName/node_modules/@cloudflare/kv-asset-handler.json]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.wasm]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.mjs]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.js]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/dist/index.js.json]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.wasm]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.mjs]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.js]
[/Users/user/Documents/Apps/React/Projects/appName/workers-site/node_modules/@cloudflare/kv-asset-handler/index.json]
 @ ./workers-site/index.js 1:0-80 44:17-31 49:37-51 71:26-43
Error: webpack returned an error. You may be able to resolve this issue by running npm install.

Not entirely sure if this is an issue with KV asset handler, this repo or wrangler ๐Ÿคทโ€โ™‚๏ธ

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.