Comments (6)
Hi @sunilgovind,
Sounds good. I have already added the sha checksum to the tar.gz and nar too
I disagree, from the point of view of automation, I don't want the script to die, it should report issues, not action in those cases and move on. When you have to work on 100's and 1000's of servers to run the patch, you don't have time to stop and debug on Production. All testing needs to be done in NonProd and get all the issue sorted before running in Production
Thanks
Josh
from cloudera-scripts-for-log4j.
Thanks for the report. We are looking into a fix.
from cloudera-scripts-for-log4j.
No worries @jtran-cloudera
I will submit a PR today, I have a number of fixes. My clients raised cases with cloudera too. So it’s in the notes for those cases
from cloudera-scripts-for-log4j.
Hi @jtran-cloudera, I am not able to send you my code via public as it's IP.
I have feed back the code changes via our Cloudera Consultant and he will pass it back via the Cloudera Case my client has open.
Thanks
Josh
from cloudera-scripts-for-log4j.
Hi @jtran-cloudera, @sdevineni, I see you added the code to validate the backup file, but it's only on jar files, it's also needed on every backup file, like the tar.gz, nar and the new uberjar code.
I see you also added
when the code doesn't match the backup, I think that is a bad idea, as it will exit the entire script at that point.Thanks
Josh
from cloudera-scripts-for-log4j.
Yes, we are working to update this for nar files as well.
if backup fails, it could be because of permissions or space elated issues. hence a fail-fast methodology is adopted to figure our the reason behind the backup creation.
from cloudera-scripts-for-log4j.
Related Issues (20)
- Print If Directory is Not Found HOT 1
- Iterator File List for JAR Files When Looking for Class HOT 1
- Sanity Check for Affected Class File
- Parametrize targetdir and backupdir for HDP/HDF HOT 1
- Can this script work on CDH5 HOT 1
- Existence of unzip is not properly tested inside delete_jndi_from_jar_files HOT 1
- /tmp as backup dir is hardcoded HOT 3
- HDP: We added code to run the patch on the active name node only. HOT 5
- Symlinks are being followed and thus backing up the wrong jar HOT 3
- HDP: Symlinks to jars not getting followed and scanned for JndiLookup.class files HOT 6
- code to backup for tar.gz is invalid HOT 3
- Temporary directories not cleaned up HOT 2
- Use git best-practices: do NOT force-push into the main branch HOT 2
- Script hangs/asks for user input if a war file has duplicate file HOT 4
- missing parameter in find HOT 3
- backupdir is hardcoded HOT 2
- Backup of tar.gz files is not occurring at the correct path with '-b' option HOT 1
- CVE-2021-45046 and CVE-2021-45105
- Files Can´t updated (cloudera-manager-daemons) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudera-scripts-for-log4j.