StartLimitInterval is a configuration option for [Service], not [Unit]

Problem:

Sep 01 06:08:14 host systemd[1]: [/etc/systemd/system/pushgateway.service:8] Unknown lvalue 'StartLimitInterval' in section 'Unit'

See doc:
https://www.freedesktop.org/software/systemd/man/systemd.unit.html#

No StartLimitInterval found.

The error occurs on version ansible 2.9.2, but works on 2.7.7.

Simple playbook.yaml
`---

• hosts: all
  roles:

  • ansible-pushgateway
    tags:
  • ansible-pushgateway

• hosts: all
  roles:

  • ansible-node-exporter
    tags:
  • ansible-node-exporter
    `

Run:
ansible-playbook -i inv --tags ansible-node-exporter playbook.yaml

Get error:
`TASK [ansible-pushgateway : Gather variables for each operating system] *******************************************************************************************************************************************
task path: /tmp/test-push-gateway/roles/ansible-pushgateway/tasks/main.yml:2
fatal: [127.0.0.1]: FAILED! => {
"msg": "No file was found when using first_found. Use errors='ignore' to allow this task to be skipped if no files are found"
}

PLAY RECAP ********************************************************************************************************************************************************************************************************
127.0.0.1 : ok=0 changed=0 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0
`

What happened?

Persistence file is not stored

May 26 14:05:50 monitor1 pushgateway[681]: time="2020-05-26T14:05:50Z" level=error msg="Problem shutting down metric storage: open /var/lib/pushgateway/persistence.in_progress.006688094: permission denied" source="main.go:121"

How to reproduce it (as minimally and precisely as possible):

Restart pushgateway with enabled persistence

• Role version:

0.2.2

• Ansible version information:

2.7.18

Anything else we need to know?:

This should be simple change in configure.yml

owner: "root" -> owner: "pushgateway_system_user"

What happened?

When user pushgateway is created, is not set to pushgateway group gid.

$ grep pushgateway /etc/passwd
pushgateway:x:996:100::/:/usr/sbin/nologin

Group 100 is users, not pushgateway (which is 996)

Did you expect to see some different?

I expect to see 996 gid (pushgateway)

How to reproduce it (as minimally and precisely as possible):

Install pushgateway using this role

Added fix here #49

What happened?
When running in check-mode, the role fails at the step "Create persistence file"
Did you expect to see some different?
This step shouldn't fail.
How to reproduce it (as minimally and precisely as possible):
Run the role in check_mode

Environment
Fedora 31

• Role version:
  Commit 66993dfd

• Ansible version information:
  ansible==2.9.7

• Variables:

pushgateway_version: 1.2.0

• Ansible playbook execution Logs:

< TASK [ansible-pushgateway : Create persistence file] >
 ------------------------------------------------------
task path: prometheus/roles/ansible-pushgateway/tasks/configure.yml:11
fatal: [telemetrydemo]: FAILED! => 
  msg: 'The conditional check ''touch_log.diff.before.state != "file"'' failed. The error was: error while evaluating conditional (touch_log.diff.before.state != "file"): ''dict object'' has no attribute ''diff'''

Anything else we need to know?:
Thanks for the good work!

What is missing?

persistence_dir variable can't be changed

Why do we need it?

To keep persistence_dir on persistent disk mounted somewhere else than default directory

Pull Request - #49