Git Product home page Git Product logo

action-module-metadata-create's Introduction

cloud-native-toolkit

action-module-metadata-create's People

Contributors

seansund avatar triceam avatar

Watchers

 avatar  avatar  avatar  avatar

action-module-metadata-create's Issues

Add support for defining module metadata using decorators

Add support for decorators in the terraform itself. These would need to be commented out since terraform does not support it but we can look for comments that contain @{keyword}. E.g.

In a variable.tf:

variable "region" {
  #@enum: us-east,us-south,eu-de
  #@scope: global
  description = "The region where the resource will be provisioned"
  type = string
}
variable "resource_group_name" {
  #@moduleRef: resource_group.name
  description = "The name of the resource group where the resource will be provisioned"
  type = string
}

Does not report an error if validation fails

When building the catalog, if there is a failure with validation, the new index.yaml (and replacement README) file is not created and no error is reported. The deploy step then occurs and results in no files being created in the gh_pages branch. This is turn results in the module not being found (404 error looking for index.yaml) when running the publish-catalog action.
image

bad variables when generating azure portworx bom

When generating the Azure Portworx BOM, the terraform ends up with a bad structure for the cluster_name variable assignment:

module "azure-portworx" {
  source = "github.com/cloud-native-toolkit/terraform-azure-portworx?ref=v0.0.1"

  azure_client_id = var.azure-portworx_azure_client_id
  azure_client_secret = var.azure-portworx_azure_client_secret
  azure_subscription_id = var.azure-portworx_azure_subscription_id
  azure_tenant_id = var.azure-portworx_azure_tenant_id
  cluster_config_file = var.azure-portworx_cluster_config_file
  cluster_type = var.azure-portworx_cluster_type
  disk_size = var.azure-portworx_disk_size
  kvdb_disk_size = var.azure-portworx_kvdb_disk_size
  portworx_config = var.azure-portworx_portworx_config
  provision = var.azure-portworx_provision
  px_enable_csi = var.azure-portworx_px_enable_csi
  px_enable_monitoring = var.azure-portworx_px_enable_monitoring
  region = var.azure-portworx_region
  resource_group_name = var.azure-portworx_resource_group_name
  variable cluster_name { = var.azure-portworx_variable cluster_name {
}

Notice the variable keyword and the curly bracket { are both included, but shouldn't be.

When mapping dependencies with moduleRefs, Maureen would like the output variable name to default to the input variable name if not provided

This would provide a short-hand to simplify the hand-coded portion of the module metadata a little.

For example:

variables:
  - name: host_key
    moduleRef:
      id: database-secret
      output: host_key

could be simplified to

variables:
  - name: host_key
    moduleRef:
      id: database-secret

This change would reduce the amount of information that would be manually provided and makes reduces the opportunities for making mistakes

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.