Comments (10)
Yes, if this can be scripted to ensure names stay consistent, lets do it!
from benchmark-wrapper.
+1 to consistent naming :-)
from benchmark-wrapper.
Wait, just to clarify because I'm not sure what y'all mean: are we modifying build_matrix
so that the quay image names stay the same? Or are we modifying the quay image names to be consistent with benchmark-wrapper benchmark names?
from benchmark-wrapper.
Talked internally a bit. Will perform the following changes to maintain consistent naming:
- Rename iperf3 image to iperf
- Rename ycsb-server image to ycsb
- Rename fs-drift image to fs_drift
- Rename fs-drift tool to fs_drift
- Create dns_perf image on quay
- Create upgrade_openshift image on quay
- Rename upgrade tool to upgrade_openshift
- Rename scale tool to scale_openshift
Might take a couple of steps to do this, as these are pretty breaking, but should be simple enough to get done.
from benchmark-wrapper.
Talked internally a bit. Will perform the following changes to maintain consistent naming:
- Rename iperf3 image to iperf
- Rename ycsb-server image to ycsb
- Rename fs-drift image to fs_drift
- Rename fs-drift tool to fs_drift
- Create dns_perf image on quay
- Create upgrade_openshift image on quay
- Rename upgrade tool to upgrade_openshift
- Rename scale tool to scale_openshift
from benchmark-wrapper.
Hey @learnitall I created the following PRs to address this issues:
from benchmark-wrapper.
Oh fantastic! I'm taking a look now!
from benchmark-wrapper.
Thanks for putting this together! This is a tough change. Left comments on the PRs- looks like there were some places here and there that were missing an updated name. I think we might want to take a look at e2e as well? I'm pretty sure the the PR for snafu would impact some scripts in there.
Only other change that I can think of is giving our GHA quay bot permissions to the updated image repositories. Looks like we're getting permission denied errors: https://github.com/cloud-bulldozer/benchmark-wrapper/runs/4287869509?check_suite_focus=true
Tomorrow I'll try to do a more thorough check and look through more CI logs to see if any other changes need to be made.
from benchmark-wrapper.
Thanks, we will let those PR as draft for the moment, there is some issues regardign renaming some tools, since this affects also the cli, we want to have input from Joe to see how we proceed.
from benchmark-wrapper.
Ah ok, sounds good!
from benchmark-wrapper.
Related Issues (20)
- Add CLI Option to Purge Empty Fields in ES
- Determine and Implement Versioning Schema
- ElasticSearch Unified Index HOT 3
- Addition of Collectors and Sample Abstraction Request HOT 2
- Create Signal Protocol HOT 4
- Extend Common Benchmark Fields HOT 4
- [Proposal] Index Environment Metadata for every benchmark HOT 4
- Quay trigger sometimes fails HOT 2
- snafu base image HOT 16
- 2 things I don't like about current cache dropping HOT 1
- backlog of ES results results in failure to get yielded results to ES?
- Can the grafana dashboard metric percentiles of bandwidth/latency in the fio ES index can use compare different run? HOT 5
- run_snafu does not protect against bad JSON data in certain failures HOT 2
- FIO and SF failed to run HOT 8
- Uperf test fails but does not exit with error HOT 2
- Elasticsearch: credential authentication HOT 5
- centos image resources .repo points to wrong URL
- scale_openshift_wrapper should expose parameters to target machineset from different labels HOT 1
- uperf Docker Image creation fails on ppc64le HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from benchmark-wrapper.