Inconsistent Benchmark and Quay Image Names about benchmark-wrapper HOT 10 OPEN

Yes, if this can be scripted to ensure names stay consistent, lets do it!

from benchmark-wrapper.

+1 to consistent naming :-)

from benchmark-wrapper.

Wait, just to clarify because I'm not sure what y'all mean: are we modifying build_matrix so that the quay image names stay the same? Or are we modifying the quay image names to be consistent with benchmark-wrapper benchmark names?

from benchmark-wrapper.

Talked internally a bit. Will perform the following changes to maintain consistent naming:

• Rename iperf3 image to iperf
• Rename ycsb-server image to ycsb
• Rename fs-drift image to fs_drift
• Rename fs-drift tool to fs_drift
• Create dns_perf image on quay
• Create upgrade_openshift image on quay
• Rename upgrade tool to upgrade_openshift
• Rename scale tool to scale_openshift

Might take a couple of steps to do this, as these are pretty breaking, but should be simple enough to get done.

from benchmark-wrapper.

Talked internally a bit. Will perform the following changes to maintain consistent naming:

• Rename iperf3 image to iperf
• Rename ycsb-server image to ycsb
• Rename fs-drift image to fs_drift
• Rename fs-drift tool to fs_drift
• Create dns_perf image on quay
• Create upgrade_openshift image on quay
• Rename upgrade tool to upgrade_openshift
• Rename scale tool to scale_openshift

from benchmark-wrapper.

Hey @learnitall I created the following PRs to address this issues:

• cloud-bulldozer/benchmark-operator#715
• #398

from benchmark-wrapper.

Oh fantastic! I'm taking a look now!

from benchmark-wrapper.

Thanks for putting this together! This is a tough change. Left comments on the PRs- looks like there were some places here and there that were missing an updated name. I think we might want to take a look at e2e as well? I'm pretty sure the the PR for snafu would impact some scripts in there.

Only other change that I can think of is giving our GHA quay bot permissions to the updated image repositories. Looks like we're getting permission denied errors: https://github.com/cloud-bulldozer/benchmark-wrapper/runs/4287869509?check_suite_focus=true

Tomorrow I'll try to do a more thorough check and look through more CI logs to see if any other changes need to be made.

from benchmark-wrapper.

Thanks, we will let those PR as draft for the moment, there is some issues regardign renaming some tools, since this affects also the cli, we want to have input from Joe to see how we proceed.

from benchmark-wrapper.

Ah ok, sounds good!

from benchmark-wrapper.