Extend Common Benchmark Fields about benchmark-wrapper HOT 4 CLOSED

This would be fantastic! It would also allow us to create really nice and specific templates for elasticsearch. One question that I have, which @mfleader talked to me about, was about the definition for config, metadata and labels. Right now we have the following:

• config represents the configuration of the benchmark itself
• metadata are fields common to all benchmarks, such as cluster_name and user
• labels are any key-value pairs that a user has passed in during snafu invocation.

I think that the metadata field is a bit confusing. We might want to look at the current fields we are placing there and whether or not they should be added into BenchmarkResult as a field.

from benchmark-wrapper.

yeah metadata is a bit weird. I'm fine if some of the fields I mentioned (start_time, end_time, run_id, etc.) are in that metadata class in the actual code as long as it gets flattened in the doc. cluster_name shouldn't be there though since it's environment specific

from benchmark-wrapper.

For newly proposed benchmark wrappers, let's say I have a field in my BenchmarkResult.data with a name, like duration, that conflicts with a field name in BenchmarkResult. If it has a different definition than BenchmarkResult.duration (specifically it is a sum of round trip times), should I just give that data field a new name?

from benchmark-wrapper.

How is start_time defined? Do they come from the beginning of the benchmarking tool or the beginning of the parent python process?

from benchmark-wrapper.