groupsix-project1's People
groupsix-project1's Issues
Inline CSS
GroupSix-Project1/contact-form.html
Line 21 in b25853b
It is a bad idea to use inline CSS it violates the DRY(do not repeat yourself) mentality. Since inline CSS cannot be reused you essentially have repeating CSS.
Age verification
Line 21 in b25853b
The age verification process is flawed. A cookie is created but isn't required to search for breweries. Each page should check that user has verified age and if they haven't go to the age verification page.
deprecated and insecure
GroupSix-Project1/php/thankyou.php
Line 6 in b25853b
The mysql_real_escape_string function has been deprecated and mysqli_real_escape_string should be used instead.
http://php.net/manual/en/function.mysql-real-escape-string.php
code cleanup
It's important to make sure all of the console.log debugging statements are removed. This is just good housekeeping practice.
leaked mysql credentials
GroupSix-Project1/php/connection.php
Line 6 in b25853b
We haven't really covered this yet but it is an important security vulnerability to be aware of. You do not want to have configuration information in your git repo. Especially if it is in a public git repository. We will cover some solutions in class on how to hide configurations like this.
search brewery finder by brewery or by city?
It appears as though this function searches by the city but the function uses a brewery variable. To make the function more intuitive the function should use the variable city. Also, you create a variable called brewery inside the function. Its a good idea to declare a different variable name to avoid confusion.
Input validation
GroupSix-Project1/php/contact-form.php
Line 102 in b25853b
It is a security vulnerability to not validate users inputs. This will also be covered in class but it is worth being aware of.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.