Git Product home page Git Product logo

cordova-plugin-inappbrowserxwalk's People

Contributors

claasbrueggemann avatar mrjoes avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

cordova-plugin-inappbrowserxwalk's Issues

window.close doesn't work as expected

Open a window from the app using then have a script that calls

window.close()

from the opened window. The plugin stops the entire app, not just the window that was opened. It should only close the opened window and return the user back to the app state that opened the window.

There are a few new features that need to be implemented for this to work properly.

  1. Return a reference to the browser window that was opened, similar to InAppBrowser
  2. Enable the type of window to open "_blank," "_self," or "_system."

Ideally, this plugin will copy the functionality from the InAppBrowser making it a drop-in replacement ๐Ÿ‘

Implements .show() and hide() functions

Hi friend.

You had made great work with this plugin.

I wish to make a suggestion: implement the functions .hide() and .show(). It will useful for showing a page only if it is full loaded.

Thank you e sorry the bad english.

start / stop events

Hi,

I have some trouble with "start" and "stop" events. Sometimes the stop event fire before the start event. The only thing I could tell is my website navigation is in ajax...
The start event fire with all loaded ressources, not only the webpage. A way to get only the url web page is to dispatch the view url like that

obj.put("url", view.getUrl());

I think there is many work to do to improve this...

Is there any way to make it work in iOS

We have used this plugin and running successfully in android. But not in iOS. Is there anyway to make it work in iOS ?

is there any other plugin which supports webRTC with inappbrowser in iOS ?

Take picture

I can't take picture from the inappweb view. But that's work on crosswalk engine. I can work on it but tell me if you have any idea.

regards.

build failed

hello, i'm trying to build my project it gives me this error

BUILD FAILED

Total time: 2.913 secs

C:\hello\platforms\android\cordova\node_modules\q\q.js:126
throw e;
^
Error code 1 for command: cmd with args: /s /c "C:\hello\platforms\android\grad
lew cdvBuildDebug -b C:\hello\platforms\android\build.gradle -Dorg.gradle.daemo
n=true"
Error: C:\hello\platforms\android\cordova\build.bat: Command failed with exit c
ode 8
at ChildProcess.whenDone (C:\Users\mark\AppData\Roaming\npm\node_modules\cor
dova\node_modules\cordova-lib\src\cordova\superspawn.js:135:23)
at ChildProcess.emit (events.js:98:17)
at maybeClose (child_process.js:766:16)
at Process.ChildProcess._handle.onexit (child_process.js:833:5)

please help!

Chromeless window and resizing

We are interested in using this plugin but need to be able to set the (x,y,w,h) of the modal webview. As well, we want to have the option to hide the toolbar.

I am checking in before we do the work at our end (we will be hiring a freelancer). Would you accept PR's to this repo to update it?

PS: Does the loadstop event fire properly now at end of page load (i.e. not ajax)? Thanks

Problem/Crash with HTML5 video fullscreen

I've created a very simple application as follows:

  • cordova 6.1.1
  • crosswalk-cordova-webview-plugin: using crosswalk 18
  • cordova-plugin-inappbrowserxwalk

The cordova app is the default template one, with just an additional button that trigger the following javascript:

window.inAppBrowserXwalk.open('http://www.youtube.com', {});

The in-app browser dialog is correctly displayed, I can navigate within youtube and play videos. The problem occur whenever I switch the video to fullscreen mode. Then in-app browser webview content disappear (I can see the cordova app), but the in-app browser toolbar with the Close button is still visible. The audio continues, but I don't get the video picture. If I press the Close button, the entire app crashes.

I've tried on 2 different platforms, ARMv7 and x86, with the same result.

Any hint or suggestion about this problem would be greatly appreciated. I would happily disable fullscreen support in the in-app browser, but it doesn't look like crosswalk has that capability.

Missing License

Hello Claas,

can you please provide a license for your work?

Thank you very much!

Build Failed error: can't find symbol XWalkCookieManager

I'm getting the following error when building for android.

/Users/me/Projects/cordova/app/platforms/android/src/com/shoety/plugin/InAppBrowserXwalk.java:17: error: cannot find symbol
import org.xwalk.core.internal.XWalkCookieManager;
                              ^
  symbol:   class XWalkCookieManager
  location: package org.xwalk.core.internal
/Users/me/Projects/cordova/app/platforms/android/src/com/shoety/plugin/InAppBrowserXwalk.java:96: error: cannot find symbol
                XWalkCookieManager mCookieManager = new XWalkCookieManager();
                ^
  symbol: class XWalkCookieManager
/Users/me/Projects/cordova/app/platforms/android/src/com/shoety/plugin/InAppBrowserXwalk.java:96: error: cannot find symbol
                XWalkCookieManager mCookieManager = new XWalkCookieManager();
                                                        ^
  symbol: class XWalkCookieManager
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
3 errors
:compileArmv7DebugJava FAILED

remove the close button

how do i remove the close button from the browser and how can i make theinappbrowserxwalk
compatible with .. please i need help

Request to implement a javascript

Great job, big help!

My feature request would be to have a close function which can be called from inside the page javascript to close the inappbrowser.
This would be specially helpful in case if the content has a e.g full screen video, and the user could close the page from within the video player layout.

Thanks!

error when build

error when bulkd cordova 6.4
latest crosswalk-webview 2.2

error: /Users/brodyr/desktop/spruce-real-estate/spruce/platforms/android/gradlew: Command failed with exit code 1 Error output:
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/Users/brodyr/Desktop/spruce-real-estate/spruce/platforms/android/src/com/shoety/plugin/InAppBrowserXwalk.java:17: error: cannot find symbol
import org.xwalk.core.internal.XWalkCookieManager;
                              ^
  symbol:   class XWalkCookieManager
  location: package org.xwalk.core.internal
/Users/brodyr/Desktop/spruce-real-estate/spruce/platforms/android/src/com/shoety/plugin/InAppBrowserXwalk.java:96: error: cannot find symbol
                XWalkCookieManager mCookieManager = new XWalkCookieManager();
                ^
  symbol: class XWalkCookieManager
/Users/brodyr/Desktop/spruce-real-estate/spruce/platforms/android/src/com/shoety/plugin/InAppBrowserXwalk.java:96: error: cannot find symbol
                XWalkCookieManager mCookieManager = new XWalkCookieManager();
                                                        ^
  symbol: class XWalkCookieManager
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
3 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileArmv7DebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:

question not issue

  1. which are the possible options which are passed in the open method?

var browser = window.inAppBrowserXwalk.open("http://google.de", options);

  1. If i want to translate this line of code that use inappbrowser plugin to use your plugin

var browserRef = window.cordova.InAppBrowser.open(flowUrl, '_blank', 'location=no,clearsessioncache=yes,clearcache=yes');

How would it be in your plugin?

Regards

Feature Request: executeScript

Maybe I'm asking too much, and this is my second feature request, but this would really match with the regular Cordova WebView.

So if you have the time to implement the executeScript feature it would be really perfect.

Code snippet to explain:
var ref = window.inAppBrowserXwalk.open(playerPath);
ref.addEventListener('loadstop', function (event) {
var loop = setInterval(function () {
ref.executeScript(
{
code: "getShouldExit()" //being a javascript function inside the XWalk view
},
function (values) {
var name = values[0];
if (name) {
clearInterval(loop);
ref.close();
}
}
);
});
});

Thank you!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.