ckhgame / villagebox Goto Github PK

by Perturbee:
I had a glitch (once), the Iron Hoe wasn't consumed when making a peasant, but the Golden Hoe was when upgrading. Not sure why I somehow kept the Iron Hoe. (Runs on server, maybe a lag spike?) Please note, it was only once, worked as expected at other times.

To prevent 2 block homes ;) Pushing players to build better fancier homes for their villagers.

I have some other mods running and would like to add to the trades of existing professions. I looked at the code and it seems like this isn't possible as the professions are hardcoded. Perhaps it would be possible to have profession trades set up from .json files?

Going even further I would recommend merging all the Pro[name] Profession classes into just Profession and having different instances of profession loaded from some descriptor file (but that would be like down the road refactoring) as that may even make it possible to define new professions easily.

The reason I am suggesting this is because there are so many cool mods and I like seeing interaction between them, and I think this mod would, if trades were customisable from .json or some other descriptor format, (and maybe even professions/upgrades), offer really good interaction with pretty much all mods to any mod pack creators wishing to better integrate all the mods to work together. For instance, the carpenter can get bibliocraft blocks and the miner can get custom ores.

But, for the purposes of just this particular issue, I would like to ask for the trade options for the professions to be configurable. That already would add a good level of mod integration depth. Basically, put the items traded, and what they are traded for, in the hands of the user, whilst providing the current trades as defaults.

Chef trade: 80 bronze coins and 1 rice flour and 1 salt ==> udon. The trade seems to be impossible to complete, because you can't put 80 bronze coins in a single inventory slot, and putting a stack in one slot and 16 in another slot doesn't work.

Dessert Chef trade: 20 silver coins and 1 orange and 1 sugar gets you canned oranges. This seems EXTREMELY expensive for food, especially considering all other Dessert Chef trades only require 10-30 bronze coins. Perhaps it's a mistake?

So I am not sure if you interested in make a custom vendor block that uses coins and that server ops can sell any item in for a set amount with a never ending stock and custom sell value. Love the mod by the way.

I'm having a couple issues with some villagers I have, and it only seems to occur when I am away from them. Sometimes, they somehow get on the outside of a closed structure. The structure itself has no easy access outside, and is in fact floating slightly above the ground. Every so often, I'll come back and find a villager below it, with some damage as if it fell through the floor.

So, I built up the floor so there was solid ground all under the structure.

I just had a situation where now it tells me my villager was killed. I guess she phased through the floor, and suffocated in the ground?

I'm running the latest VillageBox (recently did a big mod update) with a lot of other mods; if needed, I can give you those as well. What's making this bug really bad is that I have villagers set to respawn in config... but they never do. So when I lose a villager that takes a lot of investment, it sets me back quite far. I've tried adding nature totems to every villager home, but the suffocation bug sometimes occurs and there isn't anything I can do to work around that.

Finally, I don't know if this is relevant, but my structures are circular, not rectangular. There are cases where a block is barely kissing another via corner. I don't know if that might have something to do with it? They seem to want to path there quite a lot; I frequently find them pushing themselves into those corners. I'll try filling out the corners of the circle and see if it completely stops the phasing.

Edit: I have one villager, a banker, who I always had in a rectangular building, and corners fully filled. I never once had him phase through. Now, the phasing isn't very common, so I don't know if it is luck, but I've had it happen a few times in every other building with villagers, all circular. The rectangular one never had an issue. I just filled in the corners of the circular ones, and I will add more villagers to the rectangular one to compare. Could be a red herring, but I have a strong suspicion that it has something to do with hollow corners, based on this info and the fact that of all the circular buildings, the one that had the most stuff in it stuck in corners (hence preventing pathing there) had the fewest phasing incidents.

I'd like to suggest just adding oreDictionary support for the various food items so they can be used to craft food from other mods. Since they are currently otherwise useless

I think I'm supposed to do that? Why can't I do that?

Heh gross. Hamburger

Hello! First off, I absolutely love this mod.
I'm currently running a LAN server with my sister, and sometimes when one of us spawns in a villager or completes a quest, it crashes the game for the person who completes the action. Since I host the server, and we had an issue previously where she sent mail and got a villager it crashed, we decided I will be the only one sending the mail, etc.
It only happens sometimes, and it states "Concurrent Mod Exception"?
When I load up again, whatever it was I was doing has been completed, but it's kind of an annoying crash. LOL I hate having to load up MC again.

Attached is the crash file for the most recent one!
crash-2016-09-16_11.05.12-server.txt

Hi, I have just read the info of your mod, test some stuff, and i have some things to talk about.
It would be nice to have a config files were you can choose how some features work.
Also, a creative mode tab were you can find all your mod content like other mod do.

coin earning changes:
For game only focused in your mod, is really nice, very zelda style, but in some modpacks, can be a problem. You should allow in config files to dissable the coin drops. In server plays that will allow the people that dont want to use the mod (or single players) dont be forced to get coins.

I dont like the Alchemy Pot as a coin earning feature, a more comercial style block, were you can exchange goods for coins could be more rpg in some packs. (or a trade market building were you let goods and they are exchenged for some coins, like the alchemy pot, but les magic).
You produce gold, emerald, food, and you use it to earn money, that feals more right.

Villagers:
The way to get them is great, i love that. If u want them u get them, if not, they are not there.
Their trade are nice, but with the actual money earning, some trades are really cheap.
The upgrade sistem is also nice, you make them work for a special trade, with is great, only need some config file to allow or not some upgrades depending of what the game is focused.

So, at this point, the idea is great, the ingame, is also nice, but you miss some config files and optional stuff for modpack makers or players who want to focus their gaming with or without some content. When u mix to much mods, or whant to rpg, you really apreciate the mod that have great config files.

It's quite annoying in SMP I assume it's the mod doing it?

Thanks!

Great mod! Everything is working the way its supposed to so far, except my villagers are just a white box.

I'm not a java developer, I just cloned it & I want to modify it, but I don't know how to compile it into a jar.

Can you add a build.gradle or a guide to compile this resource code?

Alchemist bug: None of the potions have a texture and none of them actually do anything when you drink them (aside from turning into empty bottles like normal potions).

I looked through the code, and there does seem to be some code involving more coins per block broken for higher treasure hunt levels, but then that code never gets used in the actual "how many coins should be dropped" calculation.

Hello,

Users on my server are saying that they're having issues setting villager homes. When they ask the villager to follow them, the GUI doesn't update as shown in the trailer, but the villager indeed follows. When setting the home in a proper home (7x5x4 box with a solid roof and a door), the chat will say ".. has moved in a new home :D", but in the GUI, the text still says to set home. After this, they cannot progress with the villager. "Follow Me" and "Set Home" are the only options available while the other options are grayed out. Any tips? Thank you!

I really want to disable that. Please add a config option for it.

With the most recent update you added an option to disable the book in a players starting inventory (ty!), but there doesn't seem to be a recipe to craft it later :(

I had a nice WIP VillageBox town on a server I play on. I went offline for two days, and returned to a completely empty village. I was willing to rebuild the village's population again, but the homes are all still claimed by their nonexistent owners.

Not sure what's causing the bug, getting no messages on the client, and I don't believe the admin has found any messages on the server.

I wouldn't even care if this issue got fixed if there was a way to force-resurrect all the villagers in a village, or within a particular house. That might be something to consider, so that if your mod does break, it's not too hard to undo while waiting for a proper fix.

Loving the mod otherwise though, keep up the good work!