In CKAN 1.8, CKAN.SITE_URL is relative, and because of that, DataProxy cannot preview CSV files:

https://github.com/okfn/ckan/blob/ckan-1.8/ckan/templates/layout_base.html#L249

When trying to view CSV file preview, I get this error:

Could not load preview: DataProxy returned an error (Data transformation failed. URLError: )

The setup_template_variables() method of an IDatasetForm plugin doesn't get called when loading stage 3 additional data when creating a new dataset.

On the related items / apps page for ckan 2.0 it's a 3 column grid and 8 items is the default number to show. Which means that you get one less than is supposed to show (see attached screenshot)

Should be super simple to fix.

See the test output of failing tests at http://pastebin.com/2QFtmZ9j

Upon creating a new user (where you're redirected to the dashboard) the popover on owns user name does not load. The link goes to:
http://preview.ckan.org/api/1/util/snippet/popover-context-user.html?id=28532ad8-2d19-46e7-9d14-2cf2f8162783&name=shevski&about=null&display_name=shevski&num_followers=0&number_administered_packages=0&number_of_edits=0&is_me=true which shows a server error.

This can be done using environment variables. See http://about.travis-ci.org/docs/user/build-configuration/#Set-environment-variables

Essentially once you load more items into an activity stream the popovers that should load on the items that have been loaded in... don't.

The default values for the datastore settings in the ini file template don't work:

ckan.datastore.write_url = postgresql://ckanuser:pass@localhost/ckantest
ckan.datastore.read_url = postgresql://readonlyuser:pass@localhost/ckantest

gives:

Traceback (most recent call last):
  File "/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/nose/suite.py", line 208, in run
    self.setUp()
  File "/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/nose/suite.py", line 291, in setUp
    self.setupContext(ancestor)
  File "/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/nose/suite.py", line 300, in setupContext
    self.config.plugins.startContext(context)
  File "/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/nose/plugins/manager.py", line 99, in __call__
    return self.call(*arg, **kw)
  File "/home/seanh/.virtualenvs/ckan/local/lib/python2.7/site-packages/nose/plugins/manager.py", line 167, in simple
    result = meth(*arg, **kw)
  File "/home/seanh/Projects/ckan/ckan/ckan/ckan_nose_plugin.py", line 40, in startContext
    plugin.configure(config)
  File "/home/seanh/Projects/ckan/ckan/ckanext/datastore/plugin.py", line 59, in configure
    self._check_separate_db()
  File "/home/seanh/Projects/ckan/ckan/ckanext/datastore/plugin.py", line 134, in _check_separate_db
    raise Exception("The CKAN and datastore database are the same.")
Exception: The CKAN and datastore database are the same.

Originally: http://trac.ckan.org/ticket/2331 (opened 2012-04-28)

Original Description

Appears current default search in CKAN ORs terms rather than ANDing them (i.e. adding more terms increasing number of items found rather than reducing it).

Not sure when this crept in or if it has been there for a long time.

Discussion

There was quite a lot of back and forth discussion between myself and @kindly :-)

From using e.g. datahub.io I cannot emphasize how much this really is a UX problem (I believe @shevski has also found this an issue). When I search and add terms I expect to get fewer results and it would also help improve ordering / relevancy as you add terms (which can be quite poor on a site like datahub with many datasets)

I note this is minor and non-urgent but it is also probably very easy to do so one day if someone has the spare 10m needed it would be great to see this go in.

Each individual dataset needs more visual definition

Essentially the ckan/templates/header.html doesn't have enough {% block %}s within it and it make's customizing the header within extensions a pain. Let's add more descriptive blocks.

The new plugin does not evaluate datastore_active.

When you get an error on a taggable input the bootstrap error class get's applied to the hidden input and therefore looks bad for :focus

see #199

I am not sure what the actual problem is but will be investigating it further.

There are several issues, pull request coming...

If you have set ckan.simple_search = 1 in your config, pagination in the search does not work. What happens is that the results form page 1 occur on any other page as well.

On a resource page where the preview is failing, there is a huge white box pushing the 'additional info' off the bottom of my screen. It should be immediately under the preview failure message.

When calling package_owner_org_update a commit is fired, which triggers the notify hook. This will cause the dataset to be indexed before it is passed to extensions. We should pass a defer_commit flag on the object.

Pull request coming.

It looks wrong to me: {actor} created the link to related {related_type} {related_item}, should be {actor} added the {related_type} {related_item} to the dataset {dataset} e.g. seanh added the application Bike Share Map to the dataset Bikes, or if a related item is added that does not belong to any dataset (can be done via API) then just {actor} added the {related_type} {related_item}.

Also add activities for updating and delete related items.

Original bug at okfn/ckanext-pdeu#31

A number of users have been confused by the way the new activities count resets itself to 0 a few seconds after loading your dashboard page. Viewing the dashboard automatically marks all your activities as old, and a second later the count refreshes to 0 to reflect this. It seems like it might be less confusing if the count simply didn't refresh (and would change to 0 after the next page load).

API v3 should be promoted as the default version of the API and moved to the front page of the API docs, move API v1/2 to a legacy API page. Many of CKAN 2.0's new features are only supported in API v3.

Come up with the what is an organization text and reassign this to @johnmartin when done.

See here http://organizations.staging.ckanhosted.com/organization

It looks like commit e27b46b added an id arg to dashboard_activity_list_html() but didn't document it, now calling the function as described in the API docs 500s. Also looks like this id param is unnecessary as it should just use the id of the authorized user. Then the code that calls this function and passes an id in can be changed to not pass an id.

Also, are there any tests for this function? Apparently not or they would be failing. Need to add tests. It's just a simple wrapper function so should only need a couple of simple tests.

Really minor frontend tweak, add a bit of spacing to the More details button

Basically the buttons overflow the description when the description is long. Just needs slightly more padding-right on it.

See http://publicdata.eu/dataset/abstraction-licences-in-force-and-new-licences-determined for context

For example in the doc it's writeuser and readonlyuser, but in the template ini file it's ckanuser and readonlyuser. This means when a user copy-pastes the instructions and uses the default ini file the commands will fail. There may be other discrepancies

It says "Showing items 1 - of 80 related items found", should say "Showing items 1 - 8 of 80 related items found":

As it stands we have mixed standards for different things within the CKAN copy. I would like to suggest the following for our copy:

• Button / pseudo-button action links text should: caps on first letter. E.g. "Create new dataset" not "Create New Dataset", "Show more tags" not "Show More Tags", etc.
• Lists should never end in a full stop
• Headers should be like buttons, but the context can be capitalised. E.g. "What are Organizations?" not "What are organizations?"
• Create action links should read: "Add new group" not "Add group"
• Form submits should read: "Update group" or "Add new group" not "Update Group" or "Add New Group"
• Primary action buttons for a page should always have btn-primary on them. Eg: "Edit my profile" on viewing your profile page
• ... also they should be declarative of what they are editing. E.g. "Edit my profile" not "Edit"

Also, the /about page needs updating to be something a little nicer and the footer links need pointing to the correct pages.

For CKAN 2.0 we're using bootstrap and font awesome. These are now out of date. Let's update them for the CKAN 2.0 release.

1. Go to create a new dataset
2. Fill in name, click on next
3. type in an example or any URL and click enter
4. Screen takes you back to step one of your dataset, however, resource has been added
5. repeat
6. don't click enter to actually finish process and click on buttons
7. you get a page with multiple resources

cc @kindly @domoritz

In https://github.com/okfn/ckan/blob/master/ckanext/datastore/plugin.py#L71-L96, we're wrapping the resource_show action, adding datastore_active to the data dict. As far as I could find, there's no way of undoing it afterwards. Even plugin.unload, in the teardown in the tests, don't work.

Right now, just this test https://github.com/okfn/ckan/blob/master/ckan/tests/logic/test_action.py#L746-L754 is failing:

FAIL: ckan.tests.logic.test_action.TestAction.test_26_resource_show
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vagrant/pyenv/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/vagrant/pyenv/src/ckan/ckan/tests/logic/test_action.py", line 754, in test_26_resource_show
    assert result == resource_dict, (result, resource_dict)
AssertionError: ({u'resource_group_id': u'f11640bd-9251-4290-ad3e-a5ca196aa574', u'cache_last_updated': None, u'size_extra': u'123', u'webstore_last_updated': None, u'datastore_active': False, u'id': u'53da9e6b-d043-471b-9939-072bf5dbe580', u'size': None, u'state': u'active', u'hash': u'abc123', u'description': u'Full text. Needs escaping: " Umlaut: \xfc', u'format': u'plain text', u'alt_url': u'alt123', u'tracking_summary': {u'total': 0, u'recent': 0}, u'mimetype_inner': None, u'mimetype': None, u'cache_url': None, u'name': None, u'created': u'2013-01-28T18:08:34.621101', u'url': u'http://www.annakarenina.com/download/x=1&y=2', u'webstore_url': None, u'last_modified': None, u'position': 0, u'revision_id': u'e5ac7c17-8a3f-42db-a382-888078c7dead', u'resource_type': None}, {'resource_group_id': u'f11640bd-9251-4290-ad3e-a5ca196aa574', 'hash': u'abc123', 'description': u'Full text. Needs escaping: " Umlaut: \xfc', 'format': u'plain text', u'alt_url': u'alt123', u'size_extra': u'123', 'mimetype_inner': None, 'webstore_last_updated': None, 'id': u'53da9e6b-d043-471b-9939-072bf5dbe580', 'size': None, 'mimetype': None, 'cache_url': None, 'name': None, 'created': '2013-01-28T18:08:34.621101', 'url': u'http://www.annakarenina.com/download/x=1&y=2', 'cache_last_updated': None, 'tracking_summary': {'total': 0, 'recent': 0}, 'webstore_url': None, 'state': u'active', 'last_modified': None, 'position': 0, 'revision_id': u'e5ac7c17-8a3f-42db-a382-888078c7dead', 'resource_type': None})

What's the best way to fix it?

Datasets that belong to an organisation (e.g. http://beta.ckan.org/dataset/ckan-org) should display the org at the top of the sidebar, same as http://beta.ckan.org/dataset/an-important-dataset

@johnmartin I don't suppose there will be time to fix this before the pdeu release, but some users (or groups, or datasets) can have very large numbers, e.g.:

Maybe an easy fix would be a cut-off point where it just says e.g. "999+" instead of the real number

It looks like the /apps page shows 8 apps per page, but it arranges them in 3 columns, so you get an empty square in the bottom-right, changing to 9 apps per page should be an easy fix:

It looks like if the activity text runs longer than two lines, the third line wraps under the icon, e.g. the date in the screenshot below. Should it be indented the same as the first two lines?

Migration 64 adds a new NOT NULL column to the dashboard table but doesn't specify a default value, so the ALTER will fail if the table already contains data.

https://github.com/okfn/ckan/blob/master/ckan/migration/versions/064_add_email_last_sent_column.py

When adding resources to datasets, when the user uploads the data, we can tell the format (and it will be filled in once we exit the wizard) - but this should get filled in the form once upload is finished to avoid user adding an incorrect format

@johnmartin Another one for you, I think. Some things have HTML in their descriptions and then in the popovers, it shows raw:

There is an issue with the auth system that anonymous users can edit resources even if they are not allowed to create them.

and make sure this shows up in the plugin interfaces docs

also any other plugin interfaces that should be marked legacy or deprecated

We need helper text for instance owners at the right points (i.e. when they're adding orgs or groups or members) - and this needs to be different to any help text that displays in the interface for end users/consumers.

I suggest that we have limited help text on the public interface. E.g. I don't see how the sidebar here: http://organizations.staging.ckanhosted.com/organization is helpful. It should be departments & their descriptions (e.g. office of national statistics, department of help) and a header that makes it clear you can view the datasets these departments publish.

@johnmartin

On master when I go to a url such as http://localhost:5000/organization the main menu item should be highlighted eg organizations in this example

The reason is that the html is <li class="active"><a>... before it was <li><a class="active">...

I thought we had sorted this previously.

thanks

This line within from paster make-config ckan development.ini and development.ini:

ckan.site_logo = /img/logo.png

Needs to change to:

ckan.site_logo = /base/images/ckan-logo.png

The links in the site footer (Code of Conduct, etc.) don't go anywhere. This seems to be hard-coded:

<li><a href="#">{{ _('Terms and Conditions') }}</a></li>
<li><a href="#">{{ _('Accessibility') }}</a></li>
<li><a href="#">{{ _('Code of conduct') }}</a></li>
<li><a href="#">{{ _('Moderation policy') }}</a></li>
<li><a href="#">{{ _('FAQ') }}</a></li>
<li><a href="#">{{ _('Privacy') }}</a></li>
<li><a href="#">{{ _('Contact us') }}</a></li>
<li><a href="#">{{ _('Consultation') }}</a></li>

get it working and fix bug involving cached results.