cj-wong / photo-dash Goto Github PK

After I refactored code to be compliant with mypy, photo-dash-sds011 has consistently gotten 500 status codes from the endpoint, caused by an IndexError on this line:

This IndexError is ultimately caused by self.last_gauge_value not being correctly updated. Initially, I thought the problem lay within this commit 1b3b956, specifically:

The primary issue lies within this line:

Comment edited for line preview.

Right now, the value uses hard-coded numbers to determine the pixel width of one monospace character, given a font and size.

Plus, the 16 * 10 / 16 looks very tacky...

DashImage currently accepts an optional argument y which by default is 0. However, because this vertical offset can be something other than 0, DashImage.sections_fit() should reflect the remaining space from wherever y is, until the bottom edge.

For more information, see: cj-wong/photo-dash-base#1

I currently have the photo frame connected to a WiFi smart plug with Tasmota installed - the frame can be turned on and off automatically. Because the frame isn't capable of displaying an image when it's off, I think implementing quiet hours will save some storage writes (useful especially because SBCs primarily use micro SD cards which can fail after enough writes) along with some CPU cycles.

Currently, I think the best way to implement this is to create a secondary API endpoint (something like /quiet?) within photo-dash that only accepts GETs. The API should then return something like {"start": 21, "end": 7} where "start" references the start of quiet hours and "end" indicates when the normal API should become responsive.

Modules should check the secondary API maybe on a daily basis and save the updated information somewhere (and in memory) and check when it should not send those requests. If a module isn't aware of quiet time though, the primary API should return a no-op response (maybe 503 Service Unavailable).

Currently, there is no way to quickly observe if a file is stale. Since the photo frame indiscriminately loads images from USB storage and the timestamp on each image is in small font, I think a worthwhile enhancement is to include a file checker, most likely within the utils module.

I plan to have the image look something like...

Stale Files

Some files ($number) are potentially out of date:

- photo-dash-module: $hours_out_of_date

...and so on, maybe listing all modules (and overflowing if necessary onto more images).

Some things that should be considered:

• This functionality should be optional to preserve current behavior (so it will be enabled via the configuration file).
• Quiet hours may need to be accounted for $hours_out_of_date.