Git Product home page Git Product logo

composer-compile-plugin's People

Contributors

demeritcowboy avatar jackrabbithanna avatar seamuslee001 avatar stesi561 avatar totten avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

totten demeritcowboy seamuslee001 john-sear fuzionnz gvalfr35 jackrabbithanna thedigitaloctopus

composer-compile-plugin's Issues

composer 2.3 not compatible

It seems to have made a change so that eventname can't be null for EventDispatcher. Admittedly 2.3 was just released today, but civi download fails at the compilation task.

Error: Argument 1 passed to Composer\EventDispatcher\Event::__construct() must be of the type string, null given, called in .../vendor/civicrm/composer-compile-plugin/src/Event/CompileTaskEvent.php on line 55
In Event.php line 49:
                                                                               
  [TypeError]                                                                  
  Argument 1 passed to Composer\EventDispatcher\Event::__construct() must be of the type string, null given, called in .../vendor/civicrm/composer-compile-plugin/src/Event/CompileTaskEvent.php on line 55          
                                                                               

Exception trace:
  at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/Event.php:49
 Composer\EventDispatcher\Event->__construct() at .../vendor/civicrm/composer-compile-plugin/src/Event/CompileTaskEvent.php:55
 Civi\CompilePlugin\Event\CompileTaskEvent->__construct() at .../vendor/civicrm/composer-compile-plugin/src/TaskRunner.php:205
 Civi\CompilePlugin\TaskRunner->runTask() at .../vendor/civicrm/composer-compile-plugin/src/TaskRunner.php:169
 Civi\CompilePlugin\TaskRunner->run() at .../vendor/civicrm/composer-compile-plugin/src/TaskRunner.php:74
 Civi\CompilePlugin\TaskRunner->runDefault() at .../vendor/civicrm/composer-compile-plugin/src/Command/CompileCommand.php:75
 Civi\CompilePlugin\Command\CompileCommand->execute() at phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:1015
 Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:299
 Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:334
 Composer\Console\Application->doRun() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:130
 Composer\Console\Application->run() at phar:///usr/local/bin/composer/bin/composer:83
 require() at /usr/local/bin/composer:29

Error in composer prevents install of some packages

There seems to be an error occurring when installing some drupal modules via composer when civicrm is already installed.

Back trace shown:

Exception trace:
 () at /vendor/civicrm/composer-compile-plugin/src/Util/ComposerPassthru.php:72
 Civi\CompilePlugin\Util\ComposerPassthru->run() at phar:///usr/local/bin/composer/src/Composer/Plugin/PluginManager.php(196) : eval()'d code:117
 Civi\CompilePlugin\CompilePlugin_composer_tmp5->runTasks() at n/a:n/a
 call_user_func() at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:164
 Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:96
 Composer\EventDispatcher\EventDispatcher->dispatchScript() at phar:///usr/local/bin/composer/src/Composer/Installer.php:338
 Composer\Installer->run() at phar:///usr/local/bin/composer/src/Composer/Command/RequireCommand.php:248
 Composer\Command\RequireCommand->doUpdate() at phar:///usr/local/bin/composer/src/Composer/Command/RequireCommand.php:205
 Composer\Command\RequireCommand->execute() at phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php:245
 Symfony\Component\Console\Command\Command->run() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:835
 Symfony\Component\Console\Application->doRunCommand() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:185
 Symfony\Component\Console\Application->doRun() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:281
 Composer\Console\Application->doRun() at phar:///usr/local/bin/composer/vendor/symfony/console/Application.php:117
 Symfony\Component\Console\Application->run() at phar:///usr/local/bin/composer/src/Composer/Console/Application.php:113
 Composer\Console\Application->run() at phar:///usr/local/bin/composer/bin/composer:61
 require() at /usr/local/bin/composer:24

I can reproduce this on a clean install by doing the following:
composer create-project drupal/recommended-project civicrm
cd civicrm/
composer config extra.enable-patching true
composer config minimum-stability dev
composer require civicrm/civicrm-{core,packages,drupal-8}:'~5.32'
composer require drupal/drupalauth4ssp

Failure happens at the last step. Have also tried --with-all-dependencies and wiping vendor and composer.install in case this helps.

I suspect this might be related to: https://lab.civicrm.org/dev/drupal/-/issues/150

putenv/getenv doesn't work in php when thread safety is disabled

Apparently some distributions of php have Thread Safety => disabled (e.g. php -i | grep Thread). This makes getenv always return false, so it can't get the task. I don't have an immediate workaround other than to do it on another system and transfer it over, or instead write to known fixed filename and then read that back. Mostly putting this here in case other people run into this.

It's in src/TaskTransfer.php in export() and import().

WARNING: Failed to read compilation-task from COMPOSER_COMPILE_TASK. Please use "composer compile".
PHP Fatal error:  Uncaught InvalidArgumentException: Invalid file reference (tpl-file=NULL) in .../sites/all/modules/civicrm/vendor/civicrm/composer-compile-lib/src/Tasks/Template.php:62
Stack trace:
#0 .../sites/all/modules/civicrm/vendor/civicrm/composer-compile-lib/src/Tasks/Template.php(21): CCL\Tasks\Template::assertFileField(Array, 'tpl-file')
#1 .../sites/all/modules/civicrm/vendor/civicrm/composer-compile-lib/src/Tasks.php(24): CCL\Tasks\Template::compile(Array)
#2 Command line code(1): CCL\Tasks::template(Array)
#3 {main}
  thrown in .../sites/all/modules/civicrm/vendor/civicrm/composer-compile-lib/src/Tasks/Template.php on line 62
> @php -r 'require_once '\''.../sites/all/modules/civicrm/vendor/autoload.php'\''; Civi\CompilePlugin\TaskTransfer::import(); \CCL\Tasks::template($GLOBALS["COMPOSER_COMPILE_TASK"]);'
Script @php -r 'require_once '\''.../sites/all/modules/civicrm/vendor/autoload.php'\''; Civi\CompilePlugin\TaskTransfer::import(); \CCL\Tasks::template($GLOBALS["COMPOSER_COMPILE_TASK"]);' handling the shell-runner event returned with error code 255

PHP warning when running with -v on windows for COMPOSER_COMPILE_TASK

Warning: Use of undefined constant COMPOSER_COMPILE_TASK - assumed 'COMPOSER_COMPILE_TASK' (this will throw an Error in a future version of PHP) in Command line code on line 1

This line puts double-quotes around it:

composer-compile-plugin/src/Handler/PhpMethodHandler.php

Line 21 in af9686c

'require_once %s; %s %s($GLOBALS["COMPOSER_COMPILE_TASK"]);',

On windows the double-quotes disappear at some point along the way and so php thinks you're using a constant that hasn't been defined.

Since shell escaping is hard enough as it is and on windows is extra-bizarre, just putting this as a placeholder for now. With a quickie test it works to just put single quotes in that code line, i.e. \'. I might test that out a bit more.

Post-install listener is overly sensitive to composer start-state

Consider this update:

  • Checkout civicrm-core at revision 6f776cf7a8. The composer.lock uses composer-compile-plugin@v0.8.
  • Run composer install
  • Checkout civicrm-core at revision 29ff32ead9. The composer.lock uses composer-compile-plugin@v0.10. Additionally, there's a new item in the task-list -- based on the newer @php-script type.
  • Run composer install

This fails:

Screenshot from 2020-09-30 21-50-32

The problem is that composer initialized with plugin v0.8 (which lacks @php-script support), fetched all the new packages, and then tried to process the new tasks using the old code (still retained in memory).

I think the solution is to change this detail about the hook:

  • Right now, there's a listener for POST_INSTALL_CMD which instantiates TaskList and TaskRunner.
  • Alternatively, the listener for POST_INSTALL_CMD should start a new subprocess with @composer compile. In the new subprocess, it would load the newly downloaded code. (The main process would still exist, but it wouldn't do anything substantive, so it doesn't matter if it has the old code in memory)

Now, as long as the old+new versions both follow this convention, you'd expect that version-switches would be more robust...

PHP 8.1 / PHP 8.0 compatibility issue

this plugin is not compatible with PHP 8.1 / PHP 8.0
smoke billows out of this area:

  Composer\EventDispatcher\Event::__construct(): Argument #1 ($name) must be of type string, null given, called in vendor/civicrm/composer-compile-plugin/src/Event  
  /CompileTaskEvent.php on line 55```

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.