cityjson / cityjson-threejs-loader Goto Github PK

I got the following error after using import { CityJSONLoader, CityJSONWorkerParser } from "cityjson-threejs-loader"; in script.js.

The module was installed via npm i cityjson-threejs-loader.

May I ask what the error means, and how to fix it?

Thanks.

Uncaught Error: Cannot find module './geometry/GeometryData'
    webpackMissingModule bundle.9478a3eba0cd7458.js:56419
    js bundle.9478a3eba0cd7458.js:56419
    Webpack 6
        __webpack_require__
        js
        __webpack_require__
        <anonymous>
        <anonymous>
        <anonymous>
[bundle.9478a3eba0cd7458.js:56419:50](http://192.168.50.92:8080/bundle.9478a3eba0cd7458.js)
    webpackMissingModule bundle.9478a3eba0cd7458.js:56419
    js bundle.9478a3eba0cd7458.js:56419
    Webpack 6
        __webpack_require__
        js
        __webpack_require__
        <anonymous>
        <anonymous>
        <anonymous>

Recent version of THREE.js have some breaking changes that impact this loader. Here is a short list of changes that might be of interest in cityjson-threejs-loader:

• v152 introduces colorspace management
• v155 introduces physical lighting changes
• v163 drops support for WebGL 1

Please clarify what license does the software have. Although the code is public for everyone to see, it is legally not possible to contribute or to reuse it in any way until the conditions for it are specified.

This is practically the same issue that cjio has. Geometries are deformed because the whole transform is applied very early in the process. This leads to floating point inaccuracies.

To reproduce the problem, load files in CityJSON Ninja (which uses cityjson-threejs-loader), and notice the difference. The test files are below

simplified2.city.json
simplified2_less_translation.city.json

My suggested solution is to only apply the scale from the transform at first, do all the processing normally, and then add the translation afterwards to the position of loader.scene (or if there's a better root node, then that).

These features are not supported yet:

• Geometry instances
• MultiLineStrings
• MultiPoints

Hi,
I'm trying to use cityjson-threejs-loader in Angular 14 app.I'm trying to add cityjson-threejs-loader via the NPM package installer using,
npm install git+https://github.com/cityjson/cityjson-threejs-loader.git

your package was added to my node_modules but isn't working.
Here,

    const parser = new CityJSONWorkerParser();
    const loader = new CityJSONLoader(parser); //Got error:  TS2554: Expected 0 arguments, but got 1.
    loader.load("/assets/cityjsons/cube.city.json");

    this.scene.add(loader.scene);

Could you help me, how can I integrate cityjson-threejs-loader with angular 14.

Thanks.

Description

• The way I am using the CityJSON parser differs to the general implementation available within the core exports
• For example, CityJSONWorkerParser does a lot though I want more control and customisation over geometry generation
• Another example is to implement a parser into my own worker scripts (CityJSONWorkerParser tries to create its own worker)
• Or I may want to create an entirely different data management mechanism like streams, or worker pools
• Manually accessing ChunkParser has been helpful for me but it's not accessible via the root / index file

Expectation

• Expose all the useful classes from the parser in the root / index file (at least ChunkParser and GeometryParser)
• Core classes can be used to perform basic parsing so I can perform my own geometry processing or mesh / material application

Description

• I'd like to install cityjson-threejs-loader in my own application on CodeSandbox
• Currently there is no pre-built package on NPM to install this via npm install cityjson-threejs-loader
• The only way to use the package (at least on CodeSandbox) is to manually copy/paste the ./src directory and build it at runtime

Expectation

• Package can be installed via npm install cityjson-threejs-loader