Comments (4)
Same applies to hmac.ref_count instance defined as global object at hmac_ossl.c:284
from libsrtp.
It looks like the same problem exists in the legacy code (aes_icm.c).
This appears to be benign since the ref_count isn't used anywhere. It
might be best to simply delete the ref_count member from cipher_type_t.
On 02/17/2014 01:33 AM, Dmitry Sobinov wrote:
This issue is for openssl branch.
Field ref_count in cipher_type_t struct for aes_icm, aes_icm_192 and
aes_icm_256 global instances is incremented in aes_icm_openssl_alloc,
e.g. aes_icm_ossl.c:141:aes_icm.ref_count++;
This causes data race when someone creates srtp contexts in different
threads. I know it's pretty harmless, but it's undefined behavior
anyway, so better be fixed.—
Reply to this email directly or view it on GitHub
#39.
from libsrtp.
Leaving this issue open for now. We should address this in 2.0. The only place the ref_count appears to be used is in the crypto kernel code that simply displays the current reference count. Downstream projects may be using the ref_count due to opacity issues.
from libsrtp.
This is resolved by c8e9afe in the 2_0_0_dev branch.
from libsrtp.
Related Issues (20)
- New release would be appreciated HOT 3
- Usecase Question about libsrtp HOT 1
- Hash of v2.4.2 tarball has changed HOT 4
- srtp_create fails if setting up RTP encryption with AES-128-GCM and not specifying RTCP encryption HOT 2
- Implementation of custom encryption algorithm HOT 1
- Performance issue with OpennSSL 3 and libsrtp HOT 9
- Build fails on macOS -Wshorten-64-to-32 HOT 2
- How to compile libsrtp2.3.0 with AES-GCM cipher group support ? HOT 1
- Cross-compile libsrtp to Windows (64-bit) is failing given that OpenSSL can't be found HOT 1
- When is safe to use srtp_remove_stream? HOT 2
- Bad link in README.md HOT 1
- Release Version 3.0.0 HOT 3
- Use consistent types through out code base HOT 1
- Review public API
- libsrtp + openssl + certificates HOT 2
- remove NO_64BIT_MATH code
- Cygwin compile broken HOT 3
- update config options for crypto backend
- ABI break in 2.6.0 HOT 2
- meson ci build failing with mbedtls on macos HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsrtp.