Cygwin compile broken about libsrtp HOT 3 OPEN

I figured it could use some changes, yes - I was in a hurry to "just get it working" for my own purposes 😅. (This is exactly why I only opened an issue with the information and didn't open a PR instead; to give you guys the room to solve this more cleanly than I did.)

And yeah, I'd expect a double include like that to have some sort of guards around it... my guess it might not be getting caught because it's two different paths for the same file and the compiler isn't detecting they are the same. I'll take a look at this soon-ish and will report to Cygwin as well if it looks like that makes sense. 👍

from libsrtp.

No opinion on the correctness of the patch, but this could probably use a comment.

If they're the same file I would expect the headers to make sure double-includes work fine already tbh, perhaps this should be reported to the Cygwin folks as well?

from libsrtp.

@Thulinma I agree with @tp-m , it should be fine to include both, are there no include guards in place?

It should be noted that in the main branch integers.h has been removed, but maybe this problem has just moved to a different file now, would need to test.
Regards integers.h is in the latest release so it would be good to address this.
If the windows builds where enabled in .github/workflows/meson.yml then it should have help catch this earlier.
Thanks for reporting it and we will see what we do with it, the patch seams a bit hackish but it is a start.

from libsrtp.