Comments (4)
There are a number of improvements included here. These should be separately refined and added as separate issues with this item as the overall epic to address.
from scubagear.
@crutchfield Can you take a look and see if there's much need here beyond wanting to fix up naming or if the other items are still relevant?
from scubagear.
Is it worth some way of indicating the output was by Invoke-RunCached instead of Invoke-Scuba?
Looking at the items listed, I recommend the following:
- Rename it to make it unique just like we did for Disconnect-Tenant. FYI - Cassey is referencing Run-Cached in her regression test script. (This may be OBE as regression test script likely replaced by new testing framework.) I agree rename Invoke-RunCached to Invoke-ScubaRunCached is value added..
- When I execute Run-Cached without any parameters, it simply acts like Run-Scuba. I think we should change the default behavior to distinguish it. Perhaps by default it will set the -ExportProvider $false ? Good idea. In the functional tests we used ModifiedProviderSettings.json.
- Since we are exporting Run-Cached, do we need to add any instructions to the README? Or do we simply let developers figure this script out by examining the code on their own? I would not expect the average user to use this function. So I'd recommend we document in a deve;oper/contributor area instead of main user documentation. A nefarious user could use to fudge results to report. Otherwise, I would have suggested we just add another (already to many) switch to Invoke-Scuba for calling Invoke-RunCached and not export it.
- I think the script should output a friendly message when there is no ProviderSettingsExport.json file in the current directory or in OutPath. Right now the user gets a bunch of generic errors. Agree
from scubagear.
Break this into small separate issues for easy resolution.
from scubagear.
Related Issues (20)
- The parameter sets for the Orchestrator need re-working
- Invoke-RunCached does not automatically include -LogIn $false
- ScubaGear cmdlets should not be generic
- Refactor Teams Unit Tests
- Refactor Sharepoint Unit Tests
- Refactor Power Platform Unit Tests
- Refactor EXO Unit Tests
- Refactor Defender Unit Tests
- Refactor AAD Unit Tests
- ExchangeOnlineManagement v3.5.0 fails to connect to Exchange/Defender in non-interactive mode HOT 2
- Include Group Reference URL in ScubaResults.json
- Microsoft.Graph.* module dependencies incorrectly pinned to max 2.19
- Defender functional release testing
- AzureAD Functional Testing
- ExchangeOnline Functional Testing
- Power Platform Functional Testing
- SharePoint and OneDrive Functional Testing
- Teams Functional Testing
- Generate sample reports for Halibut HOT 4
- Update version bump workflow to work with new docs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scubagear.