Git Product home page Git Product logo

Comments (4)

schrolla avatar schrolla commented on June 4, 2024

There are a number of improvements included here. These should be separately refined and added as separate issues with this item as the overall epic to address.

from scubagear.

schrolla avatar schrolla commented on June 4, 2024

@crutchfield Can you take a look and see if there's much need here beyond wanting to fix up naming or if the other items are still relevant?

from scubagear.

crutchfield avatar crutchfield commented on June 4, 2024

Is it worth some way of indicating the output was by Invoke-RunCached instead of Invoke-Scuba?

Looking at the items listed, I recommend the following:

  1. Rename it to make it unique just like we did for Disconnect-Tenant. FYI - Cassey is referencing Run-Cached in her regression test script. (This may be OBE as regression test script likely replaced by new testing framework.) I agree rename Invoke-RunCached to Invoke-ScubaRunCached is value added..
  2. When I execute Run-Cached without any parameters, it simply acts like Run-Scuba. I think we should change the default behavior to distinguish it. Perhaps by default it will set the -ExportProvider $false ? Good idea. In the functional tests we used ModifiedProviderSettings.json.
  3. Since we are exporting Run-Cached, do we need to add any instructions to the README? Or do we simply let developers figure this script out by examining the code on their own? I would not expect the average user to use this function. So I'd recommend we document in a deve;oper/contributor area instead of main user documentation. A nefarious user could use to fudge results to report. Otherwise, I would have suggested we just add another (already to many) switch to Invoke-Scuba for calling Invoke-RunCached and not export it.
  4. I think the script should output a friendly message when there is no ProviderSettingsExport.json file in the current directory or in OutPath. Right now the user gets a bunch of generic errors. Agree

from scubagear.

schrolla avatar schrolla commented on June 4, 2024

Break this into small separate issues for easy resolution.

from scubagear.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.